Closes: #204 - NetBox 4.6.3+ compatibility#205
Merged
Conversation
…ines) Self-contained compatibility fixes for NetBox 4.6.3/4.6.4. The trigger for the GraphQL changes is NetBox 4.6.3's rewritten GraphQL filter test framework (netbox-community/netbox#22384) - not the concurrent strawberry-graphql-django 0.85 -> 0.86 bump, which did not change filter field collection. - Decorate the GraphQL filter mixins with @DataClass. strawberry's dataclass-based field collection has never picked up fields declared on plain (non-dataclass) mixin bases - verified under 0.85.0, 0.86.1 and 0.86.4 alike - so the device/vrf/interface/network filter fields were silently missing from the schema all along. NetBox 4.6.3's new auto-generated filter tests walk the filter class's MRO annotations (which do see plain mixins) and query those fields, exposing the latent gap. NetBox core decorates its own filter mixins with @DataClass for the same reason. - Narrow OSPFInstance.router_id and StaticRoute.next_hop GraphQL filters to BaseFilterLookup. Both are IPAddressField (inet)-backed; StrFilterLookup advertises substring lookups (i_ends_with, ...) whose ORM-side expected set is empty for inet columns, and the new test framework hard-fails empty expected sets as tautological. Fields typed BaseFilterLookup are skipped by the auto-emitter. - Record query-count baselines for list-view tests (assert_expected_query_count).
DanSheps
changed the title
DanSheps
self-requested a review
July 15, 2026 01:24
DanSheps
approved these changes
Jul 15, 2026
DanSheps
enabled auto-merge
July 15, 2026 01:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #204 - NetBox 4.6.3+ compatibility
CI should get green
netbox_routing/tests/query_counts.json - need to generate it in ISIS PR