fix undefined behavior from signed int overflow#30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Doom code uses unsigned BAM angles and relies on unsigned wraparound in its angle arithmetic. However, PureDOOM has the line
This casts the angles to signed integers and then does the subtraction. This is problematic because signed integer overflow is undefined behavior in C, and some compilers will emit incorrect code here. The correct code is the pattern already used a few pages further down in the
segtexturedsection:This is not just academic, it produces actual rendering artifacts under some compilers which this PR fixes: