Conversation
ast0815
approved these changes
May 12, 2026
ast0815
left a comment
ast0815
left a comment
Member
There was a problem hiding this comment.
Looks like a simple and reasonable addition.
|
Geometry is ready for visual inspection at https://dune.github.io/dunendggd/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
prism_drift1to allow a specific SAND variant while maintaining the PRISM movement logic. Users can build this specific geometry by runningmake prism_drift1(defaulting to 10,000 mm offsets), or customize by using theTMS_SHIFTandLAr_SHIFTparameters.