Skip to content

Add options to move ND-LAr and TMS - #84

Merged
ast0815 merged 5 commits into
masterfrom
prism
Apr 15, 2026
Merged

Add options to move ND-LAr and TMS #84
ast0815 merged 5 commits into
masterfrom
prism

Conversation

@mallory4869

Copy link
Copy Markdown
Member

The PRISM geometry allows you to generate geometries with movable TMS and LAr detectors. Both detectors can be moved independently or together in the X-direction. Running make prism builds the geometries with default offsets (10000 mm for both TMS and LAr).
You can also specify shift offsets for TMS and LAr separately using the TMS_SHIFT and LAr_SHIFT parameters.
For example, make prism TMS_SHIFT="15000" LAr_SHIFT="20000" moves the TMS and LAr detectors to 15000 mm and 20000 mm, respectively. Note that the maximum movable distance for PRISM is 35000 mm.
A prism_nosand option is also available to build a significantly faster geometry. Running make prism_nosand builds the same movable geometry without SAND. Similarly, to specify custom offsets, use: make prism_nosand TMS_SHIFT="15000" LAr_SHIFT="20000".

@github-actions

Copy link
Copy Markdown

Geometry is ready for visual inspection at https://dune.github.io/dunendggd/

@ast0815 ast0815 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a clever solution. Could you add the dynamically generated files to the .gitignore file so they do not accidentally get checked in?

Also, for the lines you modified, please remove the Commented out "alternative" dimensions. I doubt that anyone knows what they are for. In general: Comments should only remain in the code if they explain something. Just "old values" without context should be removed.

@mallory4869

Copy link
Copy Markdown
Member Author

Thanks for your comments! I have updated the .gitignore file. Regarding your second point about the comments, I’m not sure I fully understand which lines you’re referring to. Could you please point me to the relevant file and lines? Thanks a lot!

Comment thread duneggd/Config/ND_Hall_Air_Volume_LAr_TMS_noSAND.cfg Outdated
Comment thread Makefile Outdated
Comment thread duneggd/Config/ND_Hall_Air_Volume_LAr_TMS_SAND.cfg Outdated
@ast0815
ast0815 merged commit d9c874b into master Apr 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants