Add air to cryo window - #72
Closed
jdkio wants to merge 4 commits into
Closed
Conversation
|
Geometry is ready for visual inspection at https://dune.github.io/dunendggd/ |
Member
|
Looks like this currently introduces a geometry overlap: |
Contributor
Author
I'm not sure what it's overlapping with. I made it slightly bigger than the window to see if that's the cause |
Member
|
If you want to test this more rapidly, you can build the "tms_nosand" geometry locally and then use the overlap checking macro on that. |
Merged
Member
|
Incorporated into #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds air to the cryo window. Doesn't try to remove the warm steel after the cryo window, but that can be easily achieved by increasing the dz of the air pocket.
I tried to do that and add a plywood membrane
CompositeWindowMembrane, but I was unable to get it to work. This achieves the same thing, though it relies on the accidental coincidence that plywood and our low-density steel have similar densities.Here are slices of showing the window with air:
Y vs Z Slice
X vs Z Slice
X vs Y Slice