Update build environment to the current DUNE UPS product stack - #302
Open
SFBayLaser wants to merge 1 commit into
Open
Update build environment to the current DUNE UPS product stack#302SFBayLaser wants to merge 1 commit into
SFBayLaser wants to merge 1 commit into
Conversation
The e15/e20-qualifier product versions setup.sh pinned (root v6_12_06a,
clhep v2_4_4_1, edepsim v3_2_0, cmake v3_17_3) are no longer the
collaboration's standard container -- move to the e26-qualifier stack
(root v6_28_12, clhep v2_4_7_1, edepsim v3_2_0e) and the matching
cmake v3_9_5 available there. Also:
- link ROOT::EG explicitly (both top-level find_package and the two
targets that need it), since newer ROOT/CMake config no longer pulls
it in implicitly the way root-config --evelibs does for the plain
Makefile build.
- point PATH/LD_LIBRARY_PATH at TMS_DIR/linux/{bin,lib}, matching the
platform-scoped output layout the current CMake build produces.
Member
Author
|
Was intending this to go along with PRs 298-301... |
jdkio
approved these changes
Aug 13, 2026
jdkio
left a comment
jdkio
left a comment
Contributor
There was a problem hiding this comment.
The README should match the installation directory used by setup.sh. Right now it uses ../Linux, with a capital L.
cmake -DCMAKE_INSTALL_PREFIX=../linux ../
Other than that, I checked and it fully compiles using make
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.shwas still pinning the old e15/e20-qualifier product versions (root v6_12_06a,clhep v2_4_4_1,edepsim v3_2_0,cmake v3_17_3), which are no longer available/standard in the collaboration's current build container.Changed:
setup.shnow sets up the current e26-qualifier stack (root v6_28_12,clhep v2_4_7_1,edepsim v3_2_0e,cmake v3_9_5), andPATH/LD_LIBRARY_PATHpoint atTMS_DIR/linux/{bin,lib}to match the current CMake build's output layout.CMakeLists.txt/app/CMakeLists.txt/src/CMakeLists.txtlinkROOT::EGexplicitly where needed, since the newer ROOT/CMake config no longer pulls it in implicitly.Independent of the real-data restructuring PR stack (#298-#301) -- these are environment fixes only, no source changes.