Increase plane matching limits to increase efficiency - #295
Merged
Conversation
Member
Author
|
Sent PR for the wrong version. Fixing now |
toi42
force-pushed
the
toi_plane_matching
branch
from
August 7, 2026 17:39
702f0cc to
a47cdb0
Compare
Member
Author
|
Fixed, safe to merge now |
jdkio
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The renumbering of planes had minimal effect on single neutrino files, however when testing on N5p3, reconstruction efficiency appeared to be greatly reduced. Increasing plane match limit yields the following result. More inspection is probably required on the track matching algorithm, but this suffices as a patch for now.