Add support for Visual Studio 2026#242
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✅ Files skipped from review due to trivial changes (9)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughAdds Visual Studio 2026 support: CI matrix entries, registry/config updates, new Perl project/workspace creators, VS2026 MPC templates and platform definitions, and documentation updates including vcversion mapping. ChangesVS2026 support
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
templates/vs2026platforms.mpt (1)
12-14: Consider adding explicit settings for Win32 platform.The Win32 platform block only defines
output_subdir, while other platforms (x64, ARM, ARM64) also includecpu_defines,platform_defines,TargetMachine, andlink_options. This may be intentional if Win32 defaults are handled elsewhere, but for consistency you might consider adding explicit values:Suggested enhancement for Win32 platform block
Win32 { output_subdir = I386 + cpu_defines = _X86_ + platform_defines = WIN32 + TargetMachine = "0" // We let VC++ figure it out for us. + link_options = /machine:X86 }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@templates/vs2026platforms.mpt` around lines 12 - 14, The Win32 platform block currently only sets output_subdir = I386; update the Win32 block (symbol: Win32) to explicitly include the same platform settings used for other platforms: add cpu_defines, platform_defines, TargetMachine, and link_options entries (matching the style/values used for x64/ARM/ARM64) so the configuration is consistent rather than relying on implicit defaults; ensure names match existing keys (cpu_defines, platform_defines, TargetMachine, link_options) and values are appropriate for 32-bit Win32.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@templates/vs2026platforms.mpt`:
- Around line 12-14: The Win32 platform block currently only sets output_subdir
= I386; update the Win32 block (symbol: Win32) to explicitly include the same
platform settings used for other platforms: add cpu_defines, platform_defines,
TargetMachine, and link_options entries (matching the style/values used for
x64/ARM/ARM64) so the configuration is consistent rather than relying on
implicit defaults; ensure names match existing keys (cpu_defines,
platform_defines, TargetMachine, link_options) and values are appropriate for
32-bit Win32.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (13)
.github/workflows/cmake.yml.github/workflows/windows.ymlconfig/wireshark.mpbdocs/USAGEdocs/html/MakeProjectCreator.htmlmodules/VS2026ProjectCreator.pmmodules/VS2026WorkspaceCreator.pmregistry.pltemplates/vs2026dll.mpttemplates/vs2026exe.mpttemplates/vs2026lib.mpttemplates/vs2026libexe.mpttemplates/vs2026platforms.mpt
| my $crlf = $self->crlf(); | ||
|
|
||
| print $fh '', $crlf, | ||
| 'Microsoft Visual Studio Solution File, Format Version 12.00', $crlf; |
There was a problem hiding this comment.
Visual Studio 2026 generates an .slnx file instead of .sln
<Solution>
<Configurations>
<Platform Name="x64" />
<Platform Name="x86" />
</Configurations>
<Project Path="ConsoleApplication2026.vcxproj" />
</Solution>
There was a problem hiding this comment.
Yes, the format version has been 12 since 2012.
There was a problem hiding this comment.
How about handling the SLNX issue as a separate PR later? It doesn't seem easy at the moment because the scope of the changes is too large.
There was a problem hiding this comment.
Shouldn't it be as easy as adding this method to this module?
sub workspace_file_extension {
#my $self = shift;
return '.slnx';
}
|
What else needs to be done to get this ready to merge? GitHub Actions is going to switch |
4 participants
Summary by CodeRabbit
New Features
Documentation