Skip to content

CICD: Integration test output not visible#4230

Merged
TomOnTime merged 15 commits intomainfrom
tlim_fixtests
May 8, 2026
Merged

CICD: Integration test output not visible#4230
TomOnTime merged 15 commits intomainfrom
tlim_fixtests

Conversation

@TomOnTime
Copy link
Copy Markdown
Collaborator

@TomOnTime TomOnTime commented May 7, 2026

Fixes #4233
Fixes #4227
Fixes #4220

Issue

Issue 1: The output of the integration tests isn't displayed anywhere. It seems that the output is generated (provider tests take the right amount of time) but I don't see anyplace in the UI that I can view the results.

Issue 2: The code that sets "END" is failing with a if [[ not found error.

Resolution

  • Issue 2: It turns out the code to generate $END is using if [[ which is a bash-ism, and this GHA defaults to sh. Change to the bash shell for that step.

@TomOnTime TomOnTime changed the title CICD: Fix longtest mode CICD: Integration test output not visible May 7, 2026
@TomOnTime
Copy link
Copy Markdown
Collaborator Author

@chicks-net @cafferata: I'm stumped. It's probably something obvious. I see the output collected in ${TEST_RESULTS}/gotestsum-output.txt but I don't see any code that gives it to GitHub to display it. Any thoughts?

@cafferata
Copy link
Copy Markdown
Member

@TomOnTime The output was visible before #4153 (March 11). That PR added the > ${TEST_RESULTS}/gotestsum-output.txt redirect to the gotestsum command, which sends all stdout to the file instead of the Actions log. The file gets uploaded as an artifact, but there's nothing that prints it back to the log.

I verified this by downloading the full job log archive for this PR's run:
https://github.com/DNSControl/dnscontrol/suites/67915295585/logs?attempt=1

Looking at the TRANSIP job log, there's a 10 minute gap between END: Using: END=999 and the upload-artifact step. The tests ran, but all output went to the file.

The fix for Issue 1 would be to replace > with | tee:

gotestsum ... ./... 2>&1 | tee ${TEST_RESULTS}/gotestsum-output.txt

This writes to both the file (for the artifact) and stdout (for the Actions log).

@TomOnTime
Copy link
Copy Markdown
Collaborator Author

Ah!!! Thank you!!

@TomOnTime TomOnTime removed the longtest label May 8, 2026
@TomOnTime TomOnTime merged commit 05186f9 into main May 8, 2026
25 checks passed
@TomOnTime TomOnTime deleted the tlim_fixtests branch May 8, 2026 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Fix GHCR container access Create first release now that we're independent Fix dockerhub

2 participants