AXFRDDNS: Add missing ALPN token 'dot'#4207
Open
Mr-Foo wants to merge 1 commit intoDNSControl:mainfrom
Open
Conversation
Author
|
@hnrgrgr please review. |
Collaborator
|
Thank you for sending this! Right now the project is in transition but I hope to be able to address this once we've moved to our new git org. |
Author
|
Thank you for your consideration. I will be happy to revisit this PR once you are ready. |
TomOnTime
approved these changes
May 2, 2026
Collaborator
|
CC @hnrgrgr for confirmation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AXFRDDNS does not comply with RFC 9103 "DNS Zone Transfer over TLS " section 7.1 "Connection Establishment", which states:
Without ALPN
bind(tested 9.20.22) refuses to return the zone:While
dnscontrollogs:Since the requirement in RFC 9103 is strict, I propose to unconditionally add
NextProtos: dot.[1] RFC 9103