Skip to content

feat: LHCb modules migration#97

Draft
AcquaDiGiorgio wants to merge 5 commits intoDIRACGrid:mainfrom
AcquaDiGiorgio:issue-87-LHCb-UploadLogFile
Draft

feat: LHCb modules migration#97
AcquaDiGiorgio wants to merge 5 commits intoDIRACGrid:mainfrom
AcquaDiGiorgio:issue-87-LHCb-UploadLogFile

Conversation

@AcquaDiGiorgio
Copy link
Copy Markdown
Contributor

@AcquaDiGiorgio AcquaDiGiorgio commented Feb 4, 2026

See #87

First approach, needs review.

I tried to use the current Mock classes (MockDataManager), but I don't think this is the correct way. However, it should not vary much.

I open it as a draft because I still need to create 2 more tests and change the interactions with DIRAC.

@AcquaDiGiorgio AcquaDiGiorgio self-assigned this Feb 4, 2026
@AcquaDiGiorgio AcquaDiGiorgio linked an issue Feb 4, 2026 that may be closed by this pull request
4 tasks
@AcquaDiGiorgio
Copy link
Copy Markdown
Contributor Author

There is an issue with the FailoverRequest.
The DIRAC's workflow, during the finalize phase calls sendFailoverRequest, which through the ReqClient sends the stored requests at the workflow_commons dictionary to DIRAC.
Currently, in dirac-cwl we don't have persitency between command executions, so the operations created are lost.

@aldbr aldbr linked an issue Apr 15, 2026 that may be closed by this pull request
@AcquaDiGiorgio AcquaDiGiorgio changed the title feat: UploadLogFile command implementation feat: LHCb modules migration Apr 16, 2026
@AcquaDiGiorgio
Copy link
Copy Markdown
Contributor Author

This PR will now tackle the migration of every single module (starting from the ones used in MCSim) by importing LHCb specific functions instead of rewritting them from the ground up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate real LHCb workflow commands (Pre/PostExecution) LHCb Workflow: UploadLogFile command

1 participant