feat: replace plugin system with commands and dirac:Job hint#127
Draft
ryuwd wants to merge 3 commits intoDIRACGrid:mainfrom
Draft
feat: replace plugin system with commands and dirac:Job hint#127ryuwd wants to merge 3 commits intoDIRACGrid:mainfrom
ryuwd wants to merge 3 commits intoDIRACGrid:mainfrom
Conversation
Replace ExecutionHooksBasePlugin/QueryBasedPlugin/registry with the commands system. run_job() now reads the dirac:Job hint via JobHint from diracx-core and builds StoreOutputCommand for output storage. Commands are now async. convert_to_jdl() deprecated in favour of diracx-logic. Job wrapper template fetches CWL and params from diracX API instead of reading job.json from sandbox.
The worker retrieves workflow_id and workflow_params directly from the diracX API via get_single_job, removing the need for WorkflowID to be passed through the JDL or job config JSON.
| # input.yaml | ||
| helper_script: | ||
| class: File | ||
| path: "SB:SandboxSE|/S3/diracx-sandbox-store/sha256:abc123.tar.zst:helper.sh" |
Contributor
There was a problem hiding this comment.
I'm wondering if we shouldn't use the File location: instead of path: to provide the sandbox url and keep path just with a local path.
Since the CWL definition says The location may refer to a local or remote resource; it seems closer to what is used here. What do you think?
We could think of something similar for the input/output data as well.
Contributor
Author
There was a problem hiding this comment.
Great point! I am fixing it right now in DIRACGrid/diracx#877
Contributor
Author
There was a problem hiding this comment.
Feel free to leave comments on the PR DIRACGrid/diracx#877 as there you will find the most up to date implementation details
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace ExecutionHooksBasePlugin/QueryBasedPlugin/registry with the commands system.
run_job() now reads the dirac:Job hint via JobHint from diracx-core and builds StoreOutputCommand for output storage.
Commands are now async.
convert_to_jdl() deprecated in favour of diracx-logic.
Job wrapper template fetches CWL and params from diracX API instead of reading job.json from sandbox.