chore(docs): arch-audit #355 — CI gates, unit tests, SPEC.md, dead-code, content-drift fix - #42
Merged
Merged
Conversation
Salvage-anchor stub for actioning the docs.dig.net architectural-audit findings: content drift fix, dead scaffold removal, typecheck+lint CI, unit tests for pure locale-redirect logic, SPEC.md, README/runbook. Refs #355 Co-Authored-By: Claude <noreply@anthropic.com>
Actions the six docs.dig.net architectural-audit findings (#355):
- content drift: rewrite the dig-cat-payment pricing note to neutral
dynamic/USD-pegged wording (SYSTEM.md #125) — no flat "100 DIG" number,
no dead COMMIT_DIG fallback, no internal-file references.
- dead scaffold: remove BaseUrlWrapper (untyped, console.log('!'),
dead /chia baseUrl workaround) and its trivial Root swizzle; drop the
stale sitemap ignore entry.
- CI gates: wire typecheck (tsc) + add ESLint (flat config, react-hooks +
jsx-a11y) with a lint script and both as required steps in the test job.
- unit tests: extract the pure locale resolver to localeResolver.mjs and
cover resolveOne/detectBrowserLocale (region-override edge cases incl.
zh-HK), plus the pure helpers in gen-hreflang-sitemaps.mjs and
gen-knowledge-graph.mjs (exported + guarded main()).
- SPEC.md: normative contract — locales, build pipeline, machine artifacts
(llms.txt/knowledge-graph.json/openrpc*.json/error-codes.json), drift
gates, quality gates.
- docs hygiene: replace the yarn/GitHub-Pages README with the real
npm/S3+CloudFront flow; add runbooks/ (deploy + local-run).
Version: 0.4.6 -> 0.5.0 (minor — new CI-gate/SPEC/test capability surface).
Co-Authored-By: Claude <noreply@anthropic.com>
MichaelTaylor3d
changed the title
MichaelTaylor3d
marked this pull request as ready for review
July 18, 2026 23:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Actions the docs.dig.net architectural-audit findings (#355, health 82→): fix a HIGH content-drift bug, remove dead globally-mounted scaffold, wire the missing typecheck + lint CI gates, add unit tests for the pure locale-redirect logic, add a normative SPEC.md, and fix the stale README + add a runbook.
Closes #355.
Status
🚧 Draft — salvage-anchor stub pushed; hardening in progress by the autonomous loop (cold-repo lane).
Planned changes (from the audit)
docs/protocol/dig-cat-payment.md:51: the flat "100 DIG fallback" wording was revoked by SYSTEM.md #125 (live USD-pegged price, fail-loud). Rewrite to the neutral/dynamic wording every sibling page uses.src/components/BaseUrlWrapper.tsx(untyped, globally mounted viasrc/theme/Root.tsx, logsconsole.log('!')to prod, dead/chiaworkaround). Unmount cleanly.typecheck(tsc) + add ESLint (config + dep + CI job) per §2.4a.clientLocaleRedirect.ts(resolveOne/detectBrowserLocale) + thegen-*.mjspure helpers (§2.1/§2.3).runbooks/(§4.4).Bump
patch/minor per the final change set (stated on merge).
Generated by Claude Code