refactor(digstore-chain): consume DIG_ASSET_ID from dig-constants (#969) - #25
Merged
Merged
Conversation
WIP stub — work in progress. Co-Authored-By: Claude <noreply@anthropic.com>
digstore-chain defined its own local DIG_ASSET_ID hex literal, byte-identical to dig-constants v0.5.0's canonical value. Re-export it from dig-constants at the same `digstore_chain::dig::DIG_ASSET_ID` path instead, so the ecosystem has one source of truth (mirrors the chip35 #971 fix) and existing importers are unaffected. No dighub-core copy exists in this repo, so no further audit is needed there. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
digstore-chain's localDIG_ASSET_ID(a406d3a9…832f81) was byte-identical todig-constantsv0.5.0's canonical value.hex_literal::hex!definition withpub use dig_constants::DIG_ASSET_ID;re-exported at the SAME path (digstore_chain::dig::DIG_ASSET_ID) — existing importers unaffected.dig-constants = "0.5"todigstore-chain/Cargo.toml.DIG_ASSET_IDhex literal remains indigstore-chain(grep-verified).dighub-corecopy — none exists, so no further work there.0.15.0→0.15.1(patch — re-export only, no public API change).Verified
cargo build --locked -p digstore-chain— greencargo test -p digstore-chain --lib— 236 passed, 0 failed, 3 ignored (includesdig::tests::dig_constants_match_chip35_cross_system_contract, which now transitively checksdig-constantstoo)cargo fmt -p digstore-chain -- --check— cleancargo clippy -p digstore-chain --all-targets --all-features -- -D warnings— cleanNote
digstore-cli/src/branding.rshas a separateDIG_ASSET_ID_HEX: &strliteral (used for display/deep-links). Out of scope for this ticket (#969 scoped todigstore-chain), but flagged as a residual byte-drift risk for a future follow-up.Refs #969
🤖 Generated with Claude Code