ci(create-dig-app): add ESLint (strict) lint gate to satisfy §2.4a - #10
Merged
Conversation
Anchor for #737. Adds the missing ESLint Lint gate alongside the existing prettier/coverage/commitlint/version-increment checks. Refs #737 Co-Authored-By: Claude <noreply@anthropic.com>
Adds the missing §2.4a Lint gate: eslint.config.js (flat, @eslint/js recommended, eslint-config-prettier last), lint/lint:fix scripts, and a Lint step in ci.yml across the node 18/20/22 matrix. Templates are ignored (own typecheck/build gate). Fixes two real no-unused-vars findings in the test suite (unused loop binding and an unused import) surfaced by enabling the gate. Closes #737 Co-Authored-By: Claude <noreply@anthropic.com>
MichaelTaylor3d
marked this pull request as ready for review
July 29, 2026 11:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
Closes #737. create-dig-app was missing the Lint gate from the §2.4a release-gate set. Its CI already enforces prettier
format:check, coverage ≥80% (c8), the TS-scaffold typecheck/build, commitlint, and version-increment — but there was no ESLint check. This PR adds a strict ESLint 9 flat-config gate wired into CI, at zero errors. (The prettier half was shipped earlier in #9/v0.3.2; this completes the pair.)What changed
eslint.config.js(new) — ESLint 9 flat config:@eslint/jsrecommended over the tool's own plain-ESM source (bin//lib//test/),globals.node,eslint-config-prettierlast so theformat:checkgate stays the sole formatting authority. Globalignoresmirror.prettierignore(template trees carry__TOKEN__placeholders and have their own typecheck/build gate).package.json—lint/lint:fixscripts; devDepseslint@^9,@eslint/js@^9(pinned to match the eslint major),eslint-config-prettier,globals. Version 0.3.2 → 0.3.3 (patch — CI-gate addition, no behavior change)..github/workflows/ci.yml— aLint (eslint)step in thetestjob (node 18/20/22 matrix), afternpm ci/format-check.no-unused-vars): an unused destructure intest/nft-metadata-branches.test.jsand an unused import intest/typescript.test.js. Nolib//bin/source changes; neither masked a latent bug.Verification
npm run lint→ 0 errors / 0 warnings.npm run coverage→ 206/206 tests, 99.49% lines (≫ 80% floor).npm run format:check→ clean (incl. the neweslint.config.js).4e69cc0: CI (incl. Lint), Commitlint, Check Version Increment.Bump rationale
Patch (
ci:gate addition, no public-API/behavior change) per §2.4.