fix: correct upstream model binding management - #596
Open
ADabbler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix upstream model counting and pagination for multi-protocol bindings, make protocol-set updates atomic, and correct the model management dialog's scrolling behavior.
Observed behavior:
Before this change, the backend list endpoint paginated route rows while the UI rendered grouped model bindings, which could distort model counts and page boundaries for multi-protocol bindings. The model management dialog also used a constrained table viewport whose height and overflow behavior could prevent all rows from being accessed, including space consumed by a non-overlay horizontal scrollbar. Protocol updates were saved one route at a time, which could trigger validation against an incomplete intermediate protocol combination.
This change paginates by platform-model/upstream-model binding and replaces the complete protocol set atomically in one request. It also constrains the table viewport to the available dialog height and accounts for horizontal scrollbar space when calculating its dynamic height.
Change type
Affected areas
Verification
pnpm checkpnpm testpnpm buildgit diff --checkScreenshots, API examples, or logs
Configuration, migration, and compatibility notes
routeIDsandprotocolsfields.routeIDandprotocolrequest path remains supported.packages/api-contracttypes are updated.Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.