feat: adding multi-select boxes, allowing batch deletion#12
Merged
Conversation
|
Hi! Overall looks good, but here's a couple of things that need fixing (and followed by a couple of thoughts/suggestions you can keep/toss at your discretion).
Thoughts:
|
Contributor
Author
|
Hi, thanks for the notes!! I added the 'escape' option for mid-drawing a marquee, as well as the small comments + constant naming for the rectsIntersect function. For the setSelected note, I'll look a bit more into what you suggested (since it does make sense) and probably push a commit later after I address some other features, if that's ok! |
kyrieb-ekat
approved these changes
May 26, 2026
| startX: number; | ||
| startY: number; | ||
| currentX: number; | ||
| currentY: number; // all in image-space coords |
There was a problem hiding this comment.
is this only true for this one coord, or all four?
| canvasRef, | ||
| requestRedraw, | ||
| ); | ||
| const { getDrawingState, getDragState, getMarqueeState, cancelDrawing, cancelDrag } = |
There was a problem hiding this comment.
This is the no escape section I mentioned; there's cancelDrawing and cancelDrag but no escapeMarquee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #6