Skip to content

docs(CLAUDE): drop stale cuKron-broken gotcha (#999 closed)#1107

Merged
yingjerkao merged 1 commit into
masterfrom
docs/correct-cukron-gotcha
Jul 21, 2026
Merged

docs(CLAUDE): drop stale cuKron-broken gotcha (#999 closed)#1107
yingjerkao merged 1 commit into
masterfrom
docs/correct-cukron-gotcha

Conversation

@yingjerkao

Copy link
Copy Markdown
Collaborator

Problem

The CLAUDE.md domain-gotchas list claimed:

cuKron GPU compile is currently broken under CUDA 13 (#999) — the CUDA build is not green for that path.

But #999 is closed and cuKron compiles and runs fine under CUDA 13. A "gotcha" that flags a working path as broken actively misleads agents (e.g. it discouraged reusing the GPU Kron path — which #1105 and #1106 both do).

Fix

Remove the stale gotcha bullet.

Verification

build_gpu gpu_test_main (CUDA 13.0, RTX 4070 Ti) builds cleanly and the GPU Kron tests pass — this is the basis for #1105 (Outer via Kron) and #1106 (retire type_promote_gpu_t, which migrates the GPU Kron path). Issue #999 is CLOSED.

🤖 Generated with Claude Code

The domain gotcha claimed cuKron's GPU compile is broken under CUDA 13 (#999),
but #999 is closed and cuKron compiles and runs on CUDA 13 -- verified via a
build_gpu gpu_test_main build with passing GPU Kron tests (basis for #1105 and
#1106). A gotcha that flags a working path as broken is worse than none, so
remove it.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a note from CLAUDE.md indicating that the cuKron GPU compilation was broken under CUDA 13, suggesting that this issue has been resolved. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.71%. Comparing base (014a386) to head (df5ee51).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1107   +/-   ##
=======================================
  Coverage   72.71%   72.71%           
=======================================
  Files         226      226           
  Lines       28151    28151           
  Branches       71       71           
=======================================
  Hits        20471    20471           
  Misses       7659     7659           
  Partials       21       21           
Flag Coverage Δ
cpp 72.83% <ø> (ø)
python 64.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
C++ backend 71.93% <ø> (ø)
Python bindings 77.70% <ø> (ø)
Python package 64.13% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 014a386...df5ee51. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yingjerkao
yingjerkao merged commit b367de3 into master Jul 21, 2026
19 checks passed
@yingjerkao
yingjerkao deleted the docs/correct-cukron-gotcha branch July 21, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants