docs: record 2026-07 API decisions and archive the phase execution plans#1006
Conversation
Adds docs/dev/api-decisions.md — the maintainer rulings of 2026-07-06 (UniTensor elementwise removal, norm()->double, the trailing-underscore in-place convention, dual permute/reshape syntax) and the implemented issue-thread consensus positions (Bond immutability, shared-block safety, snake_case for new code), each linked to its issues and PRs. Archives the three phase execution plans under docs/dev/plans/ as historical decision records, with a README marking them as such (they contain machine-specific paths and are not build instructions). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 30.92% 30.92%
=======================================
Files 229 229
Lines 34760 34760
Branches 14398 14398
=======================================
Hits 10749 10749
Misses 16708 16708
Partials 7303 7303
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Code Review (docs-only)Adds Notes1. Item 1 is currently contested on its own linked issue. The preamble says treat these as settled "unless a maintainer reopens the discussion in the linked issue" — and @ianmccul has done exactly that on #997, arguing 2. 🟢 Minor — archived plans carry session artifacts. They embed a personal machine path ( VerdictDocs-only and low-risk; the sync caveat handles the in-flight-PR concern. The only substantive editorial call is whether to soften item 1's "settled" framing while #997 is actively disputed — recommended but non-blocking, and reconcilable later per your stated process. LGTM with that one note. Posted by Claude Code on behalf of @pcchen |
pcchen
left a comment
There was a problem hiding this comment.
Approving. Docs-only, low-risk, and a genuinely useful contributor-facing record — accurate to the implementing PRs and correctly attributed. The PR body's "update this file if a linked PR's scope changes materially before merging" is the right sync mechanism.
One non-blocking note (your call, reconcilable later per that process): item 1's flat "elementwise UniTensor ⊙ UniTensor is not a meaningful tensor-network operation" is the exact point @ianmccul is disputing on #997, so consider softening it to "proposed — see #997" while that discussion is open. Also optional: scrub the /Users/yjkao machine paths from the archived plans (README already marks them historical; no secrets present).
Posted by Claude Code on behalf of @pcchen
…-decisions The value-type refactor has two observable reference->value changes; only is() was noted. Add the second alongside it: the legacy `int &n() const` reference now points into this Symmetry's own variant, so writing through it no longer propagates to copies (under the shared intrusive-ptr impl it did). Documented at the accessor and recorded, together with the is() change and the byte-format preservation, as an entry in docs/dev/api-decisions.md (the repo has no CHANGELOG file; api-decisions.md is the release-notes source for API-semantics changes per #1006). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds
docs/dev/api-decisions.md— a contributor-facing record of the API rulings made on 2026-07-06 (resolving #934/#753/#675, #676, #335/#336/#381 + #421/#422, #293) and the issue-thread consensus positions implemented this cycle (#846/#841, #724, #836), each linked to the implementing PRs (#997, #998, #1000, #1001, #1005).Also archives the three phase execution plans under
docs/dev/plans/as historical records, clearly marked as such (they contain machine-specific paths from the agent sessions that executed them and are not build instructions).Docs-only; no code changes. Independent of all open chains — merge anytime. If any linked PR's scope changes materially before merging, this file should be updated in that PR.
🤖 Generated with Claude Code