SP Change Address - #136
Open
notTanveer wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements BIP-352 label-0 for change addresses. Instead of sending change back to the regular wallet address, change is now sent to a labeled silent payment address (
label = 0), making it indistinguishable from normal silent payment outputs on-chain.Changes
SP_CHANGE_LABEL = 0) with helpers for deriving both private and public keys.matchedSpendPubkey.silentPaymentAddressto matched UTXOs.createSPTransactionto use the appropriate spend key (main or labeled change) when tweaking keys, generating SP outputs, and signing.broadcastTxso the post-broadcast scan correctly recognizes change outputs sent to the labeled change address and includes them in balance calculations.SendDetailsto automatically use the labeled silent payment change address whenever the recipient is ansp1address.