Skip to content

Reduce duplicate native helpers#65

Open
snbafana wants to merge 2 commits into
codex/cued-quality-03-no-op-api-cleanupfrom
codex/cued-quality-05-native-small-cleanup
Open

Reduce duplicate native helpers#65
snbafana wants to merge 2 commits into
codex/cued-quality-03-no-op-api-cleanupfrom
codex/cued-quality-05-native-small-cleanup

Conversation

@snbafana
Copy link
Copy Markdown
Contributor

Summary

  • delete the unused live-permission request wrapper in the root window controller
  • use the existing CLI JSON decoder helper for root snapshot/status decoding
  • collapse duplicate native permission ordering and reuse the existing Messages DB path constant

Dedup decision

Rechecked the native owner surfaces before editing. trackLivePermissionRequests had no call sites, permissionOrder and defaultPermissionOrder were identical, and CuedNative already had shared helpers for CLI JSON decoding and the Messages database path. This PR reduces those duplicates in place without splitting native files or touching debugSync / messages_automation, which still have product/test references.

Verification

  • rg for trackLivePermissionRequests, defaultPermissionOrder, and defaultMessagesDBPath
  • swift build --package-path native/macos/CuedNative -c release
  • swift test --package-path native/macos/CuedNative
  • commit hook: pnpm check:app-quality
  • pre-push hook: pnpm check:ci-local

@snbafana snbafana force-pushed the codex/cued-quality-05-native-small-cleanup branch from 7e7e167 to 5c54585 Compare May 24, 2026 17:54
@snbafana snbafana changed the base branch from codex/cued-quality-04-outbound-send-decision to codex/cued-quality-03-no-op-api-cleanup May 24, 2026 17:54
@snbafana snbafana force-pushed the codex/cued-quality-05-native-small-cleanup branch from 5c54585 to 8452f7d Compare May 25, 2026 23:16
@snbafana snbafana force-pushed the codex/cued-quality-05-native-small-cleanup branch from 8452f7d to ee78e2b Compare May 26, 2026 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant