Reduce duplicate native helpers#65
Open
snbafana wants to merge 2 commits into
Open
Conversation
7e7e167 to
5c54585
Compare
5c54585 to
8452f7d
Compare
8452f7d to
ee78e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dedup decision
Rechecked the native owner surfaces before editing.
trackLivePermissionRequestshad no call sites,permissionOrderanddefaultPermissionOrderwere identical, and CuedNative already had shared helpers for CLI JSON decoding and the Messages database path. This PR reduces those duplicates in place without splitting native files or touchingdebugSync/messages_automation, which still have product/test references.Verification
rgfortrackLivePermissionRequests,defaultPermissionOrder, anddefaultMessagesDBPathswift build --package-path native/macos/CuedNative -c releaseswift test --package-path native/macos/CuedNativepnpm check:app-qualitypnpm check:ci-local