fix(release): correct dist archive names (shipped 0.2.0 release was broken) - #5
Merged
Conversation
…o cache
The `dist` target built archives named `trazo_<ver>_$os_$arch`, but in the shell
recipe `$os_` parses as the variable `os_` (undefined), dropping the OS from the
name. linux/amd64 and darwin/amd64 both collapsed to `trazo_<ver>_amd64.tar.gz`,
so the later darwin build overwrote the linux archive: the published linux
artifact actually contained a macOS binary. Brace the expansions
(`${os}_${arch}`) so every platform gets a distinct, correctly labeled archive
(trazo_<ver>_linux_amd64, _darwin_arm64, _windows_amd64, ...).
Also set `cache: false` on every actions/setup-go step (ci + release). The core
is stdlib-only with no go.sum, so setup-go's module cache had nothing to key on
and logged "Dependencies file is not found" on every run.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The v0.2.0 release I cut had broken artifacts. The
distMakefile target named archivestrazo_<ver>_$os_$arch, but in the shell recipe$os_is parsed as the variableos_(undefined, empty), so the OS was dropped from the name. Platforms then collided:linux/amd64anddarwin/amd64both ->trazo_v0.2.0_amd64.tar.gzlinux/arm64anddarwin/arm64both ->trazo_v0.2.0_arm64.tar.gzThe darwin builds ran later and overwrote the linux archives, so the published "amd64" tarball actually contained a macOS binary. Five platforms collapsed to three mislabeled files.
I have already deleted the broken v0.2.0 release and tag to stop bad downloads (repo is public).
Fix
base=$(BIN)_$(VERSION)_${os}_${arch}. Verified output:trazo_v0.2.0_linux_amd64,_linux_arm64,_darwin_amd64,_darwin_arm64,_windows_amd64-- five distinct, correctly labeled archives.cache: falseon everyactions/setup-gostep (ci + release): the core is stdlib-only with nogo.sum, so setup-go's module cache logged "Dependencies file is not found" on every run.After merge
Re-tag
v0.2.0on the new master;release.ymlwill rebuild and publish the correct binaries (its tag-vs-const Versionguard still passes, version is unchanged).🤖 Generated with Claude Code