-
Notifications
You must be signed in to change notification settings - Fork 2
Default "Member" Role. #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 1.21.1-rc
Are you sure you want to change the base?
Changes from all commits
fbb04f3
8e5bd70
8c71a24
3365c59
c1bde48
6ec6eac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -124,6 +124,10 @@ private static int removeRole(CommandContext<CommandSourceStack> context) { | |
| return failCommand(context, "commands.capitol.team.role.remove.default"); | ||
| } | ||
|
|
||
| if (Objects.equals(roleName, TeamRole.MEMBER_ROLE_NAME)) { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do heavily applaud your use of A minor note would be that since we know that This is purely stylistic, feel free to ignore this comment, either way you're doing good :) |
||
| return failCommand(context, "commands.capitol.team.role.remove.member"); | ||
| } | ||
|
|
||
| TeamRole role = database.getRoleByName(team, roleName); | ||
|
|
||
| if (role == null) { | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,6 +62,7 @@ | |
|
|
||
| "commands.capitol.team.role.remove.owner": "You cannot remove owner role.", | ||
| "commands.capitol.team.role.remove.default": "You cannot remove default role.", | ||
| "commands.capitol.team.role.remove.member": "You cannot remove member role.", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Without quotation, this sounds like broken english / bad grammar. I would suggest |
||
| "commands.capitol.team.role.remove.success": "Deleted role %s", | ||
|
|
||
| "commands.capitol.team.role.assign.no_permission": "You do not have permission to assign roles", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What in the unholy magic constant unreadable—