Skip to content

Drop the redundant type attribute that breaks the Release build #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
woksin merged 2 commits into from
Aug 11, 2026
Merged

Drop the redundant type attribute that breaks the Release build #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58de9cc
Drop the redundant type attribute that breaks the Release build
woksin Aug 11, 2026
b197840
Stop pinning the compiler toolset so the SDK's analyzers can load
woksin Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,5 @@
<PackageReference Include="StyleCop.Analyzers" PrivateAssets="All"/>
<PackageReference Include="Roslynator.Analyzers" PrivateAssets="All"/>
<PackageReference Include="Meziantou.Analyzer" PrivateAssets="All"/>
<PackageReference Include="Microsoft.Net.Compilers.Toolset" PrivateAssets="All"/>
</ItemGroup>
</Project>
1 change: 0 additions & 1 deletion Directory.Packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
<PackageVersion Include="StyleCop.Analyzers" Version="1.2.0-beta.556" NoWarn="NU5104" />
<PackageVersion Include="Roslynator.Analyzers" Version="4.16.0" />
<PackageVersion Include="Meziantou.Analyzer" Version="3.0.141" />
<PackageVersion Include="Microsoft.Net.Compilers.Toolset" Version="5.6.0" />
<!-- Testing & Specifications -->
<PackageVersion Include="Cratis.Specifications" Version="4.0.0" />
<PackageVersion Include="Cratis.Specifications.XUnit" Version="4.0.0" />
Expand Down
4 changes: 3 additions & 1 deletion Source/Stage/Api/DynamicTypeFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,9 @@ Type CreateType(string fullName, Type baseType)
return existing;
}

var typeBuilder = _module.DefineType(fullName, TypeAttributes.Public | TypeAttributes.Class, baseType);
// TypeAttributes.Class is zero — naming it beside Public says nothing the default does not already
// say, and Roslynator flags the redundant flag as an error in Release.
var typeBuilder = _module.DefineType(fullName, TypeAttributes.Public, baseType);

// Emit a public parameterless constructor chaining to the base so the JSON deserializer can instantiate it.
var constructor = typeBuilder.DefineConstructor(MethodAttributes.Public, CallingConventions.Standard, Type.EmptyTypes);
Expand Down
Loading