Fix overlay panels of command form fields inside dialogs - #115
Merged
Conversation
DropdownField, MultiSelectField and CalendarField rendered the raw PrimeReact components, so their panels stayed inside the dialog's stacking/scroll context and never became visible when opened from a CommandDialog. DropdownField now renders through the library's own Dropdown wrapper; MultiSelectField and CalendarField get the same treatment inline — the panel appended to the body and forced above modal dialogs via useOverlayZIndex. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
DropdownField,MultiSelectFieldandCalendarFieldopen their panels correctly inside command dialogs — the panels now escape the dialog's stacking and scroll context (appended to the body, forced above modal dialogs), the way the standaloneDropdownwrapper already did. (Agent setup is weird and not working StudioIssues#64)🤖 Generated with Claude Code