Add a production-named fixed tenancy registration API - #2539
Conversation
DevelopmentTenantIdResolver never consulted IHostEnvironment - it simply returned the configured tenant id, and the registration switch selected it unconditionally. Single-tenant production deployments were therefore using an API named for an environment it does not check, while that same accessor drives Chronicle namespace and Arc Mongo database resolution. UseFixedTenancy and FixedTenantIdResolver give that supported configuration a truthful name. Purely additive: DevelopmentTenantIdResolver keeps its public type and behavior by deriving from the new resolver, and DevelopmentTenantId forwards to FixedTenantId so both configuration keys read one value. UseDevelopmentTenancy is unchanged and not deprecated. Also lists Subdomain and Fixed in the unknown-resolver-type message, which omitted Subdomain. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Reviewer context, kept out of the body. Premise verified on the branch, not from the issue. Backward compatibility. Purely additive: Configuration binding, checked rather than assumed. Binding is plain reflection Mutation evidence. Each apply→run→restore in one command with
Two findings reported rather than papered over.
Gate. Debug A full Not verified: no runtime check that |
SSH.NET 2025.1.0, pulled in transitively by Testcontainers, has a high-severity advisory (GHSA-q939-rpr3-3284) published 2026-08-12 that fails restore under NU1903. Testcontainers 4.13.0 is the latest release and still resolves the vulnerable version, so pin it here alongside the existing transitive security pins. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This reverts commit 4497137.
Added
UseFixedTenancyandFixedTenantIdResolver, giving single-tenant production deployments a registration API that is not named for the development environment (Add a production-named fixed tenancy registration API #2478)Tenancy:FixedTenantIdconfiguration, whichTenancy:DevelopmentTenantIdnow forwards to (Add a production-named fixed tenancy registration API #2478)Fixed
SubdomainandFixed, which it omitted (Add a production-named fixed tenancy registration API #2478)