Skip to content

Vendors implementation --> dev#6

Merged
RMotive merged 13 commits into
devfrom
vendors_implementation
Jun 18, 2026
Merged

Vendors implementation --> dev#6
RMotive merged 13 commits into
devfrom
vendors_implementation

Conversation

@jr110

@jr110 jr110 commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

vendors implementation --> dev

@jr110 jr110 requested a review from RMotive June 4, 2026 21:06
@jr110 jr110 self-assigned this Jun 4, 2026
@jr110 jr110 added enhancement New feature or request server A server-side issue related labels Jun 4, 2026
Copilot AI review requested due to automatic review settings June 4, 2026 21:06

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces Vendor support into the security database domain model, including EF Core schema changes and integration-test coverage, while also updating several relationship metadata/connector names and bumping related testing/core package versions.

Changes:

  • Add Vendor entity + VendorsDepot/IVendorsDepot, and wire Vendors into SecurityDatabase and User relationships.
  • Add EF Core migration to create Vendors + Users_Vendors and rename/migrate join tables from Accounts_* to Users_*.
  • Extend testing utilities (DraftUtils, StoreManager) and add integration tests for VendorsDepot.

Reviewed changes

Copilot reviewed 21 out of 22 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
Integration Tests/Integration Tests.csproj Adds Core project reference for integration tests.
Integration Tests/DepotsTests/VendorsDepotTests.cs Adds integration tests for VendorsDepot update behavior.
Integration Tests/DepotsTests/ActionsDepotTests.cs Adjusts setup for permit/action update integration test.
CSM Security Database.sln Updates recorded Visual Studio version metadata.
CSM Security Database Testing/Utils/DraftUtils.cs Adds DraftUtils.Vendor() draft helper.
CSM Security Database Testing/Managers/StoreManager.cs Adds StoreVendor() helper for persisted vendor test data.
CSM Security Database Testing/CSM Security Database Testing.csproj Updates testing package versions.
CSM Security Database Core/SecurityDatabase.cs Adds DbSet<Vendor> and tweaks Sign setter accessibility.
CSM Security Database Core/Migrations/DatabaseModelSnapshot.cs Updates snapshot for vendor tables and renamed join tables.
CSM Security Database Core/Migrations/20260603042526_7_incluiding-vendors-table.Designer.cs Adds migration designer model for vendors + renamed join tables.
CSM Security Database Core/Migrations/20260603042526_7_incluiding-vendors-table.cs Adds migration creating vendors + migrating Accounts_* to Users_* join tables.
CSM Security Database Core/Entities/Vendor.cs Introduces Vendor entity and VendorType.
CSM Security Database Core/Entities/User.cs Updates relationship metadata + join-table connector names; adds Vendors navigation.
CSM Security Database Core/Entities/Solution.cs Updates dependency attribute for Permits.
CSM Security Database Core/Entities/Profile.cs Updates dependency attributes and connector usage for join tables.
CSM Security Database Core/Entities/Permit.cs Updates dependency attributes for navigations.
CSM Security Database Core/Entities/Feature.cs Updates dependency attribute for Permits.
CSM Security Database Core/Entities/Action.cs Updates dependency attribute for Permits.
CSM Security Database Core/Depots/VendorsDepot.cs Adds depot implementation for vendors.
CSM Security Database Core/Depots/Abstractions/Interfaces/IVendorsDepot.cs Adds depot interface for vendors.
CSM Security Database Core/CSM Security Database Core.csproj Updates CSM.Database.Core version; adds content-copy item.
CSM Security Database Core/Core/Constants.cs Renames join-table connector constants and adds vendor connector constants.
Files not reviewed (1)
  • CSM Security Database Core/Migrations/20260603042526_7_incluiding-vendors-table.Designer.cs: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CSM Security Database Core/CSM Security Database Core.csproj
Comment thread CSM Security Database Core/Entities/User.cs
Comment thread CSM Security Database Core/Depots/VendorsDepot.cs Outdated
Comment thread CSM Security Database Core/Entities/Vendor.cs
Comment thread CSM Security Database Core/Entities/Permit.cs
Comment thread CSM Security Database Core/Entities/Permit.cs
Comment thread CSM Security Database Testing/Managers/StoreManager.cs
@jr110 jr110 changed the title Vendors implementation --> main Vendors implementation --> dev Jun 4, 2026
@jr110 jr110 marked this pull request as draft June 4, 2026 21:34
@jr110 jr110 changed the base branch from main to dev June 4, 2026 21:35
@jr110 jr110 marked this pull request as ready for review June 5, 2026 01:31
Copilot AI review requested due to automatic review settings June 5, 2026 01:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 40 out of 41 changed files in this pull request and generated 10 comments.

Files not reviewed (1)
  • CSM Security Database Core/Migrations/20260603042526_7_incluiding-vendors-table.Designer.cs: Language not supported

Comment thread CSM Security Database Testing/CSM Security Database Testing.csproj
Comment thread CSM Security Database Core/Core/ServiceCollectionExtensions.cs
Comment thread Integration Tests/DepotsTests/UsersDepotTests.cs Outdated
Comment thread Integration Tests/DepotsTests/UserInfosTests.cs
Comment thread Integration Tests/DepotsTests/UserInfosTests.cs Outdated
Comment thread Integration Tests/DepotsTests/SolutionsDepotTests.cs
Comment thread Integration Tests/DepotsTests/ProfilesDepotTests.cs
Comment thread CSM Security Database Core/Depots/UsersDepot.cs Outdated
@RMotive RMotive merged commit 1cc5758 into dev Jun 18, 2026
1 of 2 checks passed
@RMotive RMotive deleted the vendors_implementation branch June 18, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request server A server-side issue related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants