Vendors implementation --> dev#6
Merged
Merged
Conversation
checking
There was a problem hiding this comment.
Pull request overview
This PR introduces Vendor support into the security database domain model, including EF Core schema changes and integration-test coverage, while also updating several relationship metadata/connector names and bumping related testing/core package versions.
Changes:
- Add
Vendorentity +VendorsDepot/IVendorsDepot, and wire Vendors intoSecurityDatabaseandUserrelationships. - Add EF Core migration to create
Vendors+Users_Vendorsand rename/migrate join tables fromAccounts_*toUsers_*. - Extend testing utilities (
DraftUtils,StoreManager) and add integration tests forVendorsDepot.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Integration Tests/Integration Tests.csproj | Adds Core project reference for integration tests. |
| Integration Tests/DepotsTests/VendorsDepotTests.cs | Adds integration tests for VendorsDepot update behavior. |
| Integration Tests/DepotsTests/ActionsDepotTests.cs | Adjusts setup for permit/action update integration test. |
| CSM Security Database.sln | Updates recorded Visual Studio version metadata. |
| CSM Security Database Testing/Utils/DraftUtils.cs | Adds DraftUtils.Vendor() draft helper. |
| CSM Security Database Testing/Managers/StoreManager.cs | Adds StoreVendor() helper for persisted vendor test data. |
| CSM Security Database Testing/CSM Security Database Testing.csproj | Updates testing package versions. |
| CSM Security Database Core/SecurityDatabase.cs | Adds DbSet<Vendor> and tweaks Sign setter accessibility. |
| CSM Security Database Core/Migrations/DatabaseModelSnapshot.cs | Updates snapshot for vendor tables and renamed join tables. |
| CSM Security Database Core/Migrations/20260603042526_7_incluiding-vendors-table.Designer.cs | Adds migration designer model for vendors + renamed join tables. |
| CSM Security Database Core/Migrations/20260603042526_7_incluiding-vendors-table.cs | Adds migration creating vendors + migrating Accounts_* to Users_* join tables. |
| CSM Security Database Core/Entities/Vendor.cs | Introduces Vendor entity and VendorType. |
| CSM Security Database Core/Entities/User.cs | Updates relationship metadata + join-table connector names; adds Vendors navigation. |
| CSM Security Database Core/Entities/Solution.cs | Updates dependency attribute for Permits. |
| CSM Security Database Core/Entities/Profile.cs | Updates dependency attributes and connector usage for join tables. |
| CSM Security Database Core/Entities/Permit.cs | Updates dependency attributes for navigations. |
| CSM Security Database Core/Entities/Feature.cs | Updates dependency attribute for Permits. |
| CSM Security Database Core/Entities/Action.cs | Updates dependency attribute for Permits. |
| CSM Security Database Core/Depots/VendorsDepot.cs | Adds depot implementation for vendors. |
| CSM Security Database Core/Depots/Abstractions/Interfaces/IVendorsDepot.cs | Adds depot interface for vendors. |
| CSM Security Database Core/CSM Security Database Core.csproj | Updates CSM.Database.Core version; adds content-copy item. |
| CSM Security Database Core/Core/Constants.cs | Renames join-table connector constants and adds vendor connector constants. |
Files not reviewed (1)
- CSM Security Database Core/Migrations/20260603042526_7_incluiding-vendors-table.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vendors implementation --> dev