Skip to content

Fix CSV field escaping - #64

Open
juangaitanv wants to merge 1 commit into
mainfrom
fix/csv-field-escaping
Open

Fix CSV field escaping#64
juangaitanv wants to merge 1 commit into
mainfrom
fix/csv-field-escaping

Conversation

@juangaitanv

Copy link
Copy Markdown
Contributor

Summary

Fix CSV serialization so every textual field is quoted when it contains a comma, quote, CR, or LF. The previous formatter only escaped the code field, so valid finding values such as a path containing a comma shifted subsequent columns and produced malformed CSV.

Add a focused escaping unit test and a CLI regression test that scans a Python file whose path contains a comma. No dependency was added, and ordinary CSV output remains unchanged.

Related issue

None.

Checklist

  • make ci passes locally (the same command CI runs — see CONTRIBUTING.md)
  • Ran make bootstrap once so pre-commit/pre-push hooks are active
  • Added/updated tests for the change
  • Updated docs/rules where relevant (not applicable; no interface or rule change)

@juangaitanv
juangaitanv marked this pull request as ready for review August 5, 2026 10:57

@yhoztak yhoztak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants