Migrate crate to Rust 2024 edition - #33
Open
juangaitanv wants to merge 4 commits into
Open
Conversation
juangaitanv
marked this pull request as ready for review
July 10, 2026 09:47
# Conflicts: # src/scanner/core.rs # src/scanner/output.rs
The edition-2024 migration introduced `&& let` chains that require Rust 1.88, but Cargo.toml and the README still promised 1.85 — bump both. Apply the migration's clippy rewrites to the SARIF code inherited from main: collapse the CWE `if let` nest in `build_sarif_log` into a let chain, and move `sarif_tests` to the end of `output.rs` so `items_after_test_module` no longer fires under `--all-targets`.
yhoztak
reviewed
Jul 13, 2026
Ibrahimrahhal
approved these changes
Jul 14, 2026
4 tasks
Resolve the parser, AST condition, and Django fixture conflicts while preserving the Rust 2024 migration. Add a Rust 1.88 CI check for the declared MSRV.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check HEADcargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test --all-featuresBefore merge
Cargo.tomland the README promise Rust 1.85, but the new&& letchains require Rust 1.88 or newer.