Skip to content

Close three validator gaps: savedqueries, AppModuleSiteMap, nested flow actions - #3

Merged
Cordedmink2 merged 7 commits into
mainfrom
validator-gaps
Jul 22, 2026
Merged

Close three validator gaps: savedqueries, AppModuleSiteMap, nested flow actions#3
Cordedmink2 merged 7 commits into
mainfrom
validator-gaps

Conversation

@Cordedmink2

Copy link
Copy Markdown
Owner

Fixes three cases where the validators silently rejected or skipped real-export shapes, each verified against a real client solution export (712 customization XML files, 12 unpacked cloud flows) and shipped with a regression test.

dataverse-xml-lsp 2.2.0

  • <savedqueries> wrapper root — pac exports saved queries under a <savedqueries> wrapper, but the validator only knew the singular inner savedquery, so every exported saved-query file failed as an unknown root. Now the inner <savedquery> is extracted and validated against Fetch.xsd (indicative, like forms — the bundled schema lags layoutxml/LocalizedNames).
  • <AppModuleSiteMap> root — model-driven-app sitemaps export with this root; the inner <SiteMap> is now extracted and validated against SiteMap.xsd (authoritative).
  • Both new roots are covered by the PostToolUse hook. Removed the stale live **/SavedQueries/**/*.xml → Fetch.xsd association (from both the launcher shim and the VS Code wiring), which mis-fired on the <savedqueries> root.

cloud-flow-json-lsp 2.1.0

  • The clientdata schema now validates actions nested inside Scope/If/Foreach/Switch recursively (via a definitions/action $ref), so a bogus runAfter status or a missing type on a nested action is caught instead of passing silently. Top-level behaviour is unchanged.

Testing

  • dataverse-xml-lsp: 81 passed / 0 failed
  • cloud-flow-json-lsp: 10 passed / 0 failed
  • cloud-flow LSP smoke (push + pull): all cases pass

Not included (roadmap, see the design spec)

  • Patching Fetch.xsd so saved queries validate authoritatively rather than indicatively.
  • Porting the semantic flow linter (condition rows, connection-reference resolution, hardcoded env values) into the plugin as a bundled skill.

@Cordedmink2
Cordedmink2 merged commit a2105fd into main Jul 22, 2026
0 of 2 checks passed
@Cordedmink2
Cordedmink2 deleted the validator-gaps branch July 22, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant