fix: SQS Delete Batch ID's should be distinct, which MessageID is not guaranteed to be#253
Closed
flipscholtz wants to merge 1 commit into
Closed
Conversation
…rwise deleting multiple receipts of the same message results in a 'BatchIDsNotDistinct' error and the whole batch's deletion fails. These batch ID's are just for correlation and can be set to a random UUID.
flipscholtz
force-pushed
the
fix/sqsDuplicateDeletionBatchIds
branch
from
8e56c98 to
b0e588e
Compare
flipscholtz
changed the title
lucmir
approved these changes
Aug 25, 2023
silouone
added a commit
that referenced
this pull request
Jun 19, 2026
…ueName fixes - Serverless v4 logger migration (src/log.js shim threaded into the SQS emulator). - Fix undefined this.region -> this.options.region so emitted events carry awsRegion. Re-implements #166 (thanks @zlalvani). - Make SQS deleteMessageBatch entry Ids unique within a batch (index-based, <=80 chars). Re-implements #253 (thanks @flipscholtz). - Add custom.serverless-offline-sqs.queueName override (non-mutating; strips arn so it wins for arn-bearing shapes). Re-implements #211 (thanks @mfamilia). - Backward compatible with serverless v3. Adds docker-free unit tests. v8.1.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Great catch @flipscholtz — since |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When deleting a batch of SQS messages, the Batch ID's have to be unique.
If not, a 'BatchEntryIdsNotDistinct' error is returned and none of the messages are deleted.
Setting this ID equal to the MessageID causes problems because multiple receipts of the same message will have the same MessageID, although it's not the same ReceiptHandle.
For e.g. a single batch may contain:
messageA#receipt1messageA#receipt2.In both cases, the MessageID is
messageAbut in terms of batched deletion it's two different items.According to the docs here, the ID passed to DeleteBatch is just a correlation ID, so it can be set to anything user-generated:
So we can just set it to a random UUID to avoid duplicates.