fix: remove undefined reference to this.region#166
Closed
zlalvani wants to merge 1 commit into
Closed
Conversation
|
Hello! Can we merge this! It would be good to have this live! |
silouone
added a commit
that referenced
this pull request
Jun 19, 2026
…ueName fixes - Serverless v4 logger migration (src/log.js shim threaded into the SQS emulator). - Fix undefined this.region -> this.options.region so emitted events carry awsRegion. Re-implements #166 (thanks @zlalvani). - Make SQS deleteMessageBatch entry Ids unique within a batch (index-based, <=80 chars). Re-implements #253 (thanks @flipscholtz). - Add custom.serverless-offline-sqs.queueName override (non-mutating; strips arn so it wins for arn-bearing shapes). Re-implements #211 (thanks @mfamilia). - Backward compatible with serverless v3. Adds docker-free unit tests. v8.1.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
silouone
added a commit
that referenced
this pull request
Jun 19, 2026
…nt-def fixes - Serverless v4 logger migration (src/log.js shim threaded in; handler errors are now logged instead of silently swallowed). - Fix undefined this.region -> this.options.region so emitted events carry awsRegion. Re-implements #166 (thanks @zlalvani). - Replace the infinite silent handler retry with a bounded, logged retry (default maximumRetryAttempts=10, mirrors dynamodb-streams). Re-implements #100 (thanks @dolsem). - Await this.lambda.create(...). Re-implements #249 (thanks @gabsong). - Fix kinesis-event-definition omit list (tableName -> streamName copy-paste bug). - Backward compatible with serverless v3. Adds docker-free unit tests. v7.1.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
silouone
added a commit
that referenced
this pull request
Jun 19, 2026
…no-streams fixes - Serverless v4 logger migration (src/log.js shim threaded in; handler errors are now logged). - Fix undefined this.region -> this.options.region so emitted events carry awsRegion. Re-implements #166 (thanks @zlalvani). - Throw a clear 'Table <name> does not have streams enabled' error instead of failing cryptically. Re-implements #98 (thanks @dolsem). - Rename the copy-pasted KinesisEvent class to DynamodbStreamsEvent. - Backward compatible with serverless v3. Adds docker-free unit tests. v7.1.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Thanks so much @zlalvani for catching that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
packages/serverless-offline-sqs/src/sqs.js, there is an undefined reference tothis.regionthat causes theawsRegionparameter to not be passed to lambda invocations.For context, I am using a parsing library that considers awsRegion to be a required field.