Avoid waiting for termination signal upon start-up#137
Closed
umairnadeem wants to merge 2 commits into
Closed
Conversation
| await this.start(); | ||
| await this.ready(); | ||
| this.end(); | ||
| this.ready().then(this.end).catch(() => null); |
Member
There was a problem hiding this comment.
@umairnadeem do you have some exemple of traces that calling t.end cause?
Member
|
Appreciate this, @umairnadeem! The start-up path this PR touched was rewritten in #265 (on master now, released shortly), so the code it references no longer exists. The behavior should be improved in the next release, so I'm closing this as superseded. Thanks for your contribution! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the following plugin order in serverless.yml, we currently get stuck at the start-up page:
package.json: