docs(tdx-hydro): adjudicate remaining strictness corrections - #218
Merged
CooperBigFoot merged 1 commit intoAug 12, 2026
Conversation
CooperBigFoot
merged commit Aug 12, 2026
9202115
into
pce/close-the-seven-basin-coverage-gap/milestone-7
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Criterion
The adjudicator treats every endpoint pairing at or below the inclusive 0.001 tolerance equally. For each outstanding refusal, it derives the successor upstream endpoint as
1 - established_successor_downstream_endpoint_indexand collects the sorted distinct current endpoint indexes admitted against that successor endpoint. A singleton set selectscorrection_required; an empty or two-index set selectsno_correction_required. Either valid outcome was executable before the landed records were evaluated.Measured result
The landed records select
correction_requiredfor both processing basins:2020003440,817894 -> 819270: candidate current endpoint indexes[0], selected endpoint0.2020071190,1307547 -> 1308923: candidate current endpoint indexes[0], selected endpoint0.The top-level selected set is
["2020003440", "2020071190"]. The determination records the general future correction shape and setsmilestone_dispositiontofollow_up_runtime_node_required. Milestone 7 therefore needs a separately planned runtime implementation node.Exact-zero and nearest-distance preferences were unused. The selector depends only on the admitted pairing relation.
Dedicated fixtures prove that an exact-zero pairing cannot collapse a two-candidate set and that a singleton candidate at endpoint 1 selects endpoint 1.
Gates
cargo fmt --check: passed.cargo clippy --workspace --all-targets -- -D warnings: passed.cargo check --workspace --all-targets: passed.cargo test --workspace: passed.cargo build --workspace: passed.HFX_BINARY="$(pwd -P)/target/debug/hfx" uv run --project adapters/tdx-hydro python adapters/tdx-hydro/test_build_adapter.py: passed, 130 tests.Scope
This is a decision-only change. It does not alter adapter behavior, versions, verdicts, tolerance bands, guards, schemas, the specification, or release files. No acquired-source compilation, compiled basin output, cloud activity, provisioning, S3 access, NGA contact, source-defect reporting, assembly, teardown, release work, tag, push, or PR creation occurred. Both evidence trees remained content-unread and metadata-identical. The
2020071190superseded prior estimate remains recorded unchanged.