Record a data-backed verdict for every absent basin - #214
Merged
CooperBigFoot merged 3 commits intoAug 10, 2026
Conversation
_adjudicate_duplicate previously returned BasinVerdict.SOURCE_DEFECT as an unconditional literal while computing but never consulting spatially_equal and coordinate_sequences_equal. The verdict is now derived by _derive_duplicate_verdict from the measured geometry. The rule is defined only over valid, finite, two-dimensional polygonal geometry; every other input refuses with ValueError before Shapely .equals() is reached. The emitted evidence records the raw measurements plus a machine-readable derivation rule and selected branch so a ledger reader can recompute the verdict.
The ledger records one verdict for each of the seven absent processing basins, preserved byte-for-byte from adjudicator stdout. adapter_version 0.1.0 and git_revision bca87d8 identify the examined adapter build, while the adjudicator at bd2606c derived the verdicts. Both evidence trees were read only and verified unchanged by a before-and-after metadata inventory.
CooperBigFoot
deleted the
pce/close-the-seven-basin-coverage-gap/milestone-6
branch
August 10, 2026 09:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Milestone 6 of the seven-basin coverage-gap vision. Three steps, all reviewed and merged into this integration branch.
What this delivers
A durable, data-backed verdict for each of the seven TDX-Hydro processing basins absent from the 55-of-62-basin HFX v0.3.0 dataset. Each basin carries exactly one of
source defect,adapter strictness, ortransfer failure, derived from evidence rather than asserted._adjudicate_duplicatepreviously returnedBasinVerdict.SOURCE_DEFECTas an unconditional literal while computing but never consulting its own measurements. The verdict is now a function of the measured geometry, defined only over non-empty, valid, finite, two-dimensional polygonal geometry, with everything else refusing before Shapely.equals()is reached.Provenance
adapter.adapter_version0.1.0andadapter.git_revisionbca87d8identify the adapter build under examination — the build under which the seven basins are absent. The verdicts were derived by the adjudicator atbd2606c. These identities are kept separate in the README; the JSON is the single verdict authority.Verification
Not in scope
No adapter-strictness correction (m7), no compilation (m8), no source-defect report drafted or transmitted (m9, human-gated), no assembly (m10), no S3 access, no cloud provisioning, no deletion, and no version bump or tag.