Use scaling region during AWS config bootstrap - #36
Open
Cool-fire wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes startup when the AWS region environment variables are unset.
Why:
pkg/service.NewConfigpreviously calledconfig.LoadDefaultConfigwithout a region, then used that config to create the STS client forAssumeRole. WhenAWS_REGIONorAWS_DEFAULT_REGIONwas missing, the bootstrap path could fail before the per-region config value was applied, even though each scaling target already provides its own region.What changed:
config.WithRegion(region)when a scaling region is providedVerification:
go test ./...-> could not run in this sandbox becausegois not installed (/usr/bin/bash: line 1: go: command not found)make-> could not run in this sandbox becausegois not installed (/bin/sh: 1: go: not found)gofmt -w "pkg/service/service.go" "pkg/service/service_test.go"-> could not run in this sandbox becausegofmtis not installed (/usr/bin/bash: line 1: gofmt: command not found)Limitations:
The code and test were updated, but formatting/build/test verification still needs to be run in an environment with the Go toolchain installed.
Files changed
Session
View session
Generated by Gambits Staging