You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not sure I want to update every script on our control system.
Maybe add the old WidgetColor back in:
package org.csstudio.display.builder.model.properties
// Class in original package that wraps the new one to satisfy
// existing scripts
public class WidgetColor extends org.phoebus.ui.color.WidgetColor
{
}
@kasemir
I added wrapper for all 4 of the moved classes
I marked them all deprecated so that we can safely clean up in the future... but for the time being things 5.0.3/4 should be completely backward compatible
Deprecating them is fundamentally good, but doesn't help much with scripts since in a script you don't see that it's deprecated.
Could add a log message to the constructor, so whenever a script calls it, there's a log message which helps raise awareness. Not saying that's necessary right now, but that could be a step between now and removal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3776
maintains backward compatibility as described in the comments
Checklist
Testing:
Documentation: