Skip to content

fix WidgetColor import Issue #3776#3777

Open
shroffk wants to merge 5 commits intomasterfrom
issue_3776
Open

fix WidgetColor import Issue #3776#3777
shroffk wants to merge 5 commits intomasterfrom
issue_3776

Conversation

@shroffk
Copy link
Copy Markdown
Member

@shroffk shroffk commented Apr 14, 2026

fixes #3776
maintains backward compatibility as described in the comments

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • If not, explain how you tested your changes
  • Documentation:

    • The feature is documented

@shroffk shroffk requested a review from kasemir April 14, 2026 20:11
@kasemir
Copy link
Copy Markdown
Collaborator

kasemir commented Apr 14, 2026

Not sure I want to update every script on our control system.
Maybe add the old WidgetColor back in:

package org.csstudio.display.builder.model.properties

// Class in original package that wraps the new one to satisfy
// existing scripts
public class WidgetColor extends org.phoebus.ui.color.WidgetColor
{

}

@shroffk shroffk added the wip work in progress label Apr 14, 2026
@shroffk shroffk marked this pull request as draft April 14, 2026 20:48
@shroffk shroffk marked this pull request as ready for review April 15, 2026 13:54
@shroffk
Copy link
Copy Markdown
Member Author

shroffk commented Apr 15, 2026

@kasemir
I added wrapper for all 4 of the moved classes
I marked them all deprecated so that we can safely clean up in the future... but for the time being things 5.0.3/4 should be completely backward compatible

@kasemir
Copy link
Copy Markdown
Collaborator

kasemir commented Apr 15, 2026

Deprecating them is fundamentally good, but doesn't help much with scripts since in a script you don't see that it's deprecated.
Could add a log message to the constructor, so whenever a script calls it, there's a log message which helps raise awareness. Not saying that's necessary right now, but that could be a step between now and removal.

@shroffk shroffk removed the wip work in progress label Apr 15, 2026
@shroffk
Copy link
Copy Markdown
Member Author

shroffk commented Apr 15, 2026

Deprecating them is fundamentally good, but doesn't help much with scripts since in a script you don't see that it's deprecated.

Ya, I was wondering what to do about this...but I think a log message is the next best thing

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scripts that use WidgetColor are broken

2 participants