⚡ Bolt: optimize fkColumnsForEdge node scans to O(1) string decodes

.jules/bolt.md

@@ -77,3 +77,6 @@ Optimized metric route processing to O(N) by creating a mapping of routes direct
 ## 2024-07-13 - [Optimize Export Dictionary FK lookups]
 **Learning:** Found O(N * C * E) performance bottleneck in ERD export dictionaries due to repeated array searching with `edges.some()` inside a nested loop over nodes and columns.
 **Action:** Replace repeated linear array scans for edges by precomputing O(1) Set lookups of foreign key column handles per node before looping.
+## 2024-07-28 - Avoid O(N) Array Iteration when Parsing Handled Identifiers
+**Learning:** During ERD column verification processes like `fkColumnsForEdge`, checking edge mappings using `.find()` alongside a `.replace()`-based encoding inside a loop over all column handles results in significant O(C) string allocation overhead per edge.
+**Action:** Expose a centralized `parseColumnNameFromHandle` decoding utility instead, allowing extraction of the target string in O(1). Then use `.some()` to verify column existence natively, bypassing intermediate string re-encoding.

frontend/src/erd/export.ts

@@ -2,7 +2,7 @@ import type { Node, Edge } from '@xyflow/react';
 import { normalizeBusinessGroupColor } from './businessGroups';
 import type { IndexRecommendation } from './cardinality';
 import type { ForeignKeyEdgeData, TableNodeData } from './convert';
-import { sourceColumnHandleId, targetColumnHandleId } from './handleUtils';
+import { parseColumnNameFromHandle } from './handleUtils';
 
 export * from './exportDataDictionary';
 
@@ -67,14 +67,16 @@ function fkColumnsForEdge(
     return { sourceColumns, targetColumns };
   }
 
-  const sourceHandleColumn = (sourceNode.data.columns || [])
-    .find((column) => sourceColumnHandleId(column.column_name) === edge.sourceHandle)
-    ?.column_name;
-  const targetHandleColumn = (targetNode.data.columns || [])
-    .find((column) => targetColumnHandleId(column.column_name) === edge.targetHandle)
-    ?.column_name;
-  if (sourceHandleColumn && targetHandleColumn) {
-    return { sourceColumns: [sourceHandleColumn], targetColumns: [targetHandleColumn] };
+  const parsedSource = parseColumnNameFromHandle(edge.sourceHandle);
+  const parsedTarget = parseColumnNameFromHandle(edge.targetHandle);
+
+  if (parsedSource && parsedTarget) {
+    const sourceHandleColumn = (sourceNode.data.columns || []).some((c) => c.column_name === parsedSource) ? parsedSource : null;
+    const targetHandleColumn = (targetNode.data.columns || []).some((c) => c.column_name === parsedTarget) ? parsedTarget : null;
+
+    if (sourceHandleColumn && targetHandleColumn) {
+      return { sourceColumns: [sourceHandleColumn], targetColumns: [targetHandleColumn] };
+    }
   }
 
   const fallbackSource = (sourceNode.data.columns || [])

frontend/src/erd/handleUtils.test.ts

@@ -1,5 +1,5 @@
 import { describe, it, expect } from 'vitest';
-import { sanitizeHandleId, sourceColumnHandleId, targetColumnHandleId } from './handleUtils';
+import { sanitizeHandleId, sourceColumnHandleId, targetColumnHandleId, parseColumnNameFromHandle } from './handleUtils';
 
 describe('handleUtils', () => {
   describe('sanitizeHandleId', () => {
@@ -35,4 +35,37 @@ describe('handleUtils', () => {
       expect(targetColumnHandleId('id')).toBe('tgt-c-0069-0064');
     });
   });
+
+  describe('parseColumnNameFromHandle', () => {
+    it('should handle null or undefined', () => {
+      expect(parseColumnNameFromHandle(null)).toBeNull();
+      expect(parseColumnNameFromHandle(undefined)).toBeNull();
+    });
+
+    it('should handle empty base handles', () => {
+      expect(parseColumnNameFromHandle('c-empty')).toBe('');
+    });
+
+    it('should handle empty source handles', () => {
+      expect(parseColumnNameFromHandle('src-c-empty')).toBe('');
+    });
+
+    it('should parse a base handle id', () => {
+      expect(parseColumnNameFromHandle('c-0069-0064')).toBe('id');
+    });
+
+    it('should parse a source handle id', () => {
+      expect(parseColumnNameFromHandle('src-c-0069-0064')).toBe('id');
+    });
+
+    it('should parse a target handle id', () => {
+      expect(parseColumnNameFromHandle('tgt-c-0069-0064')).toBe('id');
+    });
+
+    it('should parse special and unicode characters', () => {
+      expect(parseColumnNameFromHandle('c-0075-0073-0065-0072-005f-0069-0064')).toBe('user_id');
+      expect(parseColumnNameFromHandle('c-0069-0064-005f-ac00')).toBe('id_가');
+      expect(parseColumnNameFromHandle('tgt-c-0069-0064-005f-1f680')).toBe('id_🚀');
+    });
+  });
 });

frontend/src/erd/handleUtils.ts

@@ -14,3 +14,19 @@ export function sourceColumnHandleId(columnName: string): string {
 export function targetColumnHandleId(columnName: string): string {
   return `tgt-${sanitizeHandleId(columnName)}`
 }
+
+export function parseColumnNameFromHandle(handleId: string | null | undefined): string | null {
+  if (!handleId) return null;
+  const parts = handleId.split('-');
+  const startIndex = parts[0] === 'src' || parts[0] === 'tgt' ? 2 : 1;
+
+  if (parts.length <= startIndex || parts[startIndex] === 'empty') {
+    return '';
+  }
+
+  try {
+    return String.fromCodePoint(...parts.slice(startIndex).map((hex) => parseInt(hex, 16)));
+  } catch {
+    return null;
+  }
+}