🎨 Palette: Make context-rich disabled buttons keyboard discoverable - #740
🎨 Palette: Make context-rich disabled buttons keyboard discoverable#740seonghobae wants to merge 1 commit into
Conversation
Change the native `disabled` attribute on the '접근 관리' (Access Management) button in `ExportModal` to `aria-disabled="true"` with a `preventDefault()` onClick handler. This ensures screen reader users navigating via keyboard can discover the element and hear its `aria-describedby` hint, which was previously inaccessible. Updated CSS to preserve visual disabled styles.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
|
Superseded by #698, which defines and tests the complete focusable |
Understood. Acknowledging that this work is now obsolete and superseded by #698. Stopping work on this task. |
💡 What: Replaced the native
disabledattribute on the '접근 관리' (Access Management) button in theExportModalwitharia-disabled="true". Also added anonClick={(e) => e.preventDefault()}handler to intercept interaction and updated CSS to match the native:disabledvisual styles.🎯 Why: Native HTML
disabledattributes remove elements from the browser's accessibility tree's tab order. This means screen reader users relying on keyboard navigation could not discover the button at all, and therefore could not hear the important contextual hint linked viaaria-describedbyexplaining why access management is disabled. This change keeps the button focusable but functionally disabled.📸 Before/After:
Tabwould completely bypass the button, never hearing the helper text "접근 권한 관리는 프로젝트 권한 설정에서 처리합니다."disabledstate via ARIA, and immediately read the contextual hint. Visual presentation remains identical.♿ Accessibility: Fixes a critical discoverability gap for context-rich disabled interactive elements. Verified via Vitest using
.focus()and@testing-library/user-eventto simulate keyboard navigation and blocking.PR created automatically by Jules for task 15819193529099259529 started by @seonghobae