Skip to content

🎨 Palette: Make context-rich disabled buttons keyboard discoverable - #740

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette-a11y-disabled-hint-15819193529099259529
Closed

🎨 Palette: Make context-rich disabled buttons keyboard discoverable#740
seonghobae wants to merge 1 commit into
mainfrom
palette-a11y-disabled-hint-15819193529099259529

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What: Replaced the native disabled attribute on the '접근 관리' (Access Management) button in the ExportModal with aria-disabled="true". Also added an onClick={(e) => e.preventDefault()} handler to intercept interaction and updated CSS to match the native :disabled visual styles.

🎯 Why: Native HTML disabled attributes remove elements from the browser's accessibility tree's tab order. This means screen reader users relying on keyboard navigation could not discover the button at all, and therefore could not hear the important contextual hint linked via aria-describedby explaining why access management is disabled. This change keeps the button focusable but functionally disabled.

📸 Before/After:

  • Before: Keyboard users pressing Tab would completely bypass the button, never hearing the helper text "접근 권한 관리는 프로젝트 권한 설정에서 처리합니다."
  • After: Keyboard users can focus the button. Screen readers will announce its name, its disabled state via ARIA, and immediately read the contextual hint. Visual presentation remains identical.

Accessibility: Fixes a critical discoverability gap for context-rich disabled interactive elements. Verified via Vitest using .focus() and @testing-library/user-event to simulate keyboard navigation and blocking.


PR created automatically by Jules for task 15819193529099259529 started by @seonghobae

Change the native `disabled` attribute on the '접근 관리' (Access Management) button in `ExportModal` to `aria-disabled="true"` with a `preventDefault()` onClick handler. This ensures screen reader users navigating via keyboard can discover the element and hear its `aria-describedby` hint, which was previously inaccessible. Updated CSS to preserve visual disabled styles.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 19 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5c7a74bf-fa32-411b-8605-8f5dd94ec270

📥 Commits

Reviewing files that changed from the base of the PR and between 72afe6d and 7a5e88d.

📒 Files selected for processing (4)
  • .jules/palette.md
  • frontend/src/components/modals/ExportModal.test.tsx
  • frontend/src/components/modals/ExportModal.tsx
  • frontend/src/styles.css

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Superseded by #698, which defines and tests the complete focusable aria-disabled contract for every unavailable export action, including the access-management placeholder. Consolidating there avoids overlapping ExportModal and stylesheet changes.

@seonghobae seonghobae closed this Aug 5, 2026
@google-labs-jules

Copy link
Copy Markdown

Superseded by #698, which defines and tests the complete focusable aria-disabled contract for every unavailable export action, including the access-management placeholder. Consolidating there avoids overlapping ExportModal and stylesheet changes.

Understood. Acknowledging that this work is now obsolete and superseded by #698. Stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant