Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,3 +77,6 @@ Optimized metric route processing to O(N) by creating a mapping of routes direct
## 2024-07-13 - [Optimize Export Dictionary FK lookups]
**Learning:** Found O(N * C * E) performance bottleneck in ERD export dictionaries due to repeated array searching with `edges.some()` inside a nested loop over nodes and columns.
**Action:** Replace repeated linear array scans for edges by precomputing O(1) Set lookups of foreign key column handles per node before looping.
## 2024-07-28 - Avoid Array.from for String Iteration in High-Frequency Paths
**Learning:** Using `Array.from(string, callback).join("-")` for string processing creates unnecessary intermediate array allocations, adding garbage collection (GC) pressure, especially when executed in high-frequency paths like generating handle IDs for nodes and edges in large graphs.
**Action:** Replace `Array.from(string)` processing with a standard `for...of` loop (which natively supports Unicode code point iteration) and direct string concatenation to eliminate array allocations and improve execution speed.
18 changes: 13 additions & 5 deletions frontend/src/erd/handleUtils.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,18 @@
export function sanitizeHandleId(columnName: string): string {
const encoded = Array.from(columnName, (char) => {
// Array.from only yields non-empty Unicode scalars, so codePointAt(0) is defined.
return char.codePointAt(0)!.toString(16).padStart(4, '0')
}).join('-')
if (!columnName) return 'c-empty';

return `c-${encoded || 'empty'}`
let encoded = '';
let isFirst = true;
for (const char of columnName) {
if (!isFirst) {
encoded += '-';
}
// for...of correctly iterates over Unicode code points in JavaScript strings
encoded += char.codePointAt(0)!.toString(16).padStart(4, '0');
isFirst = false;
}

return `c-${encoded}`;
}

export function sourceColumnHandleId(columnName: string): string {
Expand Down
Loading