feat(ui): strengthen generated-index readability and focus states - #360
feat(ui): strengthen generated-index readability and focus states#360seonghobae wants to merge 5 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 40 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
8271210 to
060abbb
Compare
Buyer-visible problem
The generated directory index is the product. Its rows, empty state, hover state, focus state, and dark-mode presentation must remain readable without relying on low opacity, emoji-specific rendering, or an underline that runs beneath a decorative icon.
Current-base implementation
This branch was rebuilt from protected
mastercommit060abbb0ea40a9b1b3bcd5e322272324b6256a30, after CSP PR #363 integrated. It preserves the exact emitted-style/CSP byte-identity contract and applies one bounded presentation change:li + li, avoiding a final-row exception;role="status", the existing deterministic information icon,aria-hidden="true", and reduced-motion behavior;:focus-visible, while retaining the existing 2px outline around the complete interactive target;Test-first verification
GeneratedIndexReadabilityTestexercises real generatedindex.htmloutput for:CspHashTestcontinues to independently recompute the hash from the exact emitted<style>bytes.CHANGELOG.mdanddocs/doctoring/generated-index-readability.mdrecord the scope, WCAG 2.2 engineering basis, APA 7 references, calculated ratios, and the explicit boundary that automated source tests are evidence rather than a formal conformance claim.Exact-head gates
At head
fd3749a58714aeb27ac6774ba86a8b72cf6354f5, CI including JaCoCo coverage verification, Security Scan, Semgrep, and CodeRabbit status have succeeded, and no unresolved review thread is present. The PR is ready for review but must not merge until an independent non-author approval applies to this exact head and every repository-required gate remains successful. Queued, pending, skipped-required, cancelled, absent, stale-head, or failed checks are not success.