Skip to content

feat(ui): strengthen generated-index readability and focus states - #360

Open
seonghobae wants to merge 5 commits into
masterfrom
palette-ux-css-polish-5845135229647237706
Open

feat(ui): strengthen generated-index readability and focus states#360
seonghobae wants to merge 5 commits into
masterfrom
palette-ux-css-polish-5845135229647237706

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Buyer-visible problem

The generated directory index is the product. Its rows, empty state, hover state, focus state, and dark-mode presentation must remain readable without relying on low opacity, emoji-specific rendering, or an underline that runs beneath a decorative icon.

Current-base implementation

This branch was rebuilt from protected master commit 060abbb0ea40a9b1b3bcd5e322272324b6256a30, after CSP PR #363 integrated. It preserves the exact emitted-style/CSP byte-identity contract and applies one bounded presentation change:

  • separate adjacent rows with li + li, avoiding a final-row exception;
  • replace opacity-based empty-state text with explicit light and dark foreground colors;
  • retain role="status", the existing deterministic information icon, aria-hidden="true", and reduced-motion behavior;
  • underline only the textual span on hover and :focus-visible, while retaining the existing 2px outline around the complete interactive target;
  • place dark-mode overrides after their corresponding base rules; and
  • leave file order, URLs, escaping, CSP, indexing policy, hidden-file policy, and filesystem behavior unchanged.

Test-first verification

GeneratedIndexReadabilityTest exercises real generated index.html output for:

  1. parent, first, middle, and last row order;
  2. exactly one semantic empty-state row;
  3. adjacent-row separator structure;
  4. explicit light/dark empty-state colors and absence of opacity;
  5. dark-mode cascade order;
  6. text-only hover/focus underline with the full-target outline preserved;
  7. reduced-motion retention; and
  8. numeric sRGB contrast thresholds for ordinary text and authored focus colors.

CspHashTest continues to independently recompute the hash from the exact emitted <style> bytes. CHANGELOG.md and docs/doctoring/generated-index-readability.md record the scope, WCAG 2.2 engineering basis, APA 7 references, calculated ratios, and the explicit boundary that automated source tests are evidence rather than a formal conformance claim.

Exact-head gates

At head fd3749a58714aeb27ac6774ba86a8b72cf6354f5, CI including JaCoCo coverage verification, Security Scan, Semgrep, and CodeRabbit status have succeeded, and no unresolved review thread is present. The PR is ready for review but must not merge until an independent non-author approval applies to this exact head and every repository-required gate remains successful. Queued, pending, skipped-required, cancelled, absent, stale-head, or failed checks are not success.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: facb3c4e-c928-46fb-a039-adf0d1bb300c

📥 Commits

Reviewing files that changed from the base of the PR and between 060abbb and fd3749a.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • docs/doctoring/generated-index-readability.md
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/GeneratedIndexReadabilityTest.kt

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae changed the title 🎨 Palette: 디렉토리 목록 가독성 향상 및 다크 모드 CSS 순서 교정 feat(ui): strengthen generated-index readability and focus states Aug 5, 2026
@seonghobae
seonghobae marked this pull request as draft August 5, 2026 06:19
This was referenced Aug 5, 2026
@seonghobae seonghobae closed this Aug 5, 2026
@seonghobae
seonghobae force-pushed the palette-ux-css-polish-5845135229647237706 branch from 8271210 to 060abbb Compare August 5, 2026 20:20
@seonghobae
seonghobae marked this pull request as ready for review August 5, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant