fix(security): pin provider egress and repair the Atheris lock - #96
fix(security): pin provider egress and repair the Atheris lock#96seonghobae wants to merge 37 commits into
Conversation
ModelClient._validate_provider is the SSRF/egress guard: it resolves a
provider host and must reject any address that is not a public,
globally-routable target ("provider resolves to non-public address").
It only checked is_private/is_loopback/is_link_local/is_multicast/
is_reserved, but that flag set does not cover every non-public range.
RFC 6598 shared address space (100.64.0.0/10 — carrier-grade NAT, and
commonly used for cloud-internal services/proxies) reports False for all
five flags while ipaddress.is_global is also False, so a provider whose
host resolved into 100.64.0.0/10 (or its IPv4-mapped ::ffff:100.64.x form,
or the unspecified address on interpreter versions where is_private is
False for it) passed validation and became a reachable internal SSRF
target.
Fix: also reject `not ip_address.is_global`. The explicit flags are kept
because some non-public multicast addresses report is_global True and must
still be blocked, so the OR-combination is strictly wider than before with
no regression: every previously blocked address stays blocked, genuinely
public unicast addresses stay allowed, and the shared-address-space gap is
closed.
Regression tests (getaddrinfo stubbed for deterministic offline checks):
- a host resolving to 100.64.0.1 must be rejected (fails before this fix)
- a host resolving to 8.8.8.8 must still be accepted (guards over-blocking)
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01REEc4WtvMHbGD23XK6xbLK
The required Semgrep (multi-language SAST) gate failed on five findings, blocking OpenCode approval on the SSRF-egress fix. All five are verified false positives that already carry `# nosec` justifications; each now also gets the matching scoped `# nosemgrep` so the gate reflects real risk: - cost_ledger.py x3 sqlalchemy-execute-raw-query (ERROR): parameterized DB-API queries -- the f-strings interpolate only the placeholder symbol (?/%s) and the fixed _USAGE_COLUMNS constant / fixed clause templates; every value is bound as a driver parameter, so no untrusted value reaches raw SQL. - orchestrator.py unverified-ssl-context (ERROR): secure by default (verify_tls=True -> ssl.create_default_context()); ssl._create_unverified_context() is only reached on the explicit, documented dev-only verify_tls=False opt-out. - orchestrator.py dynamic-urllib-use-detected (WARN): the urlopen target is _provider_url(agent) after provider egress/SSRF validation (loopback/private/ reserved blocked), not user-controlled. Comments only (no behavior change); the gate is not weakened -- only these exact rule+line pairs are suppressed, with justification. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01REEc4WtvMHbGD23XK6xbLK
…3.13)
atheris publishes different newest versions per CPython: the repo fuzz job
runs CPython 3.11 where the newest published wheel is 3.0.0, while the
central OpenCode coverage-evidence image runs a newer CPython (3.13+)
where only 3.1.0 is published. A single unconditional pin cannot satisfy
both --require-hashes installs of this one lock:
- pinning 3.0.0 fails the central coverage image build on 3.13+
("No matching distribution found for atheris==3.0.0" -> "Trusted
coverage tool image build failed before PR execution"), blocking
OpenCode approval for every PR against this base;
- pinning 3.1.0 fails the repo's own "Atheris coverage-guided" job on
3.11 ("No matching distribution found for atheris==3.1.0").
Split the pin with environment markers (atheris==3.0.0 for
python_version < 3.13, atheris==3.1.0 for >= 3.13) and regenerate the
hash lock with the recorded `uv pip compile ... --python-version 3.11
--universal` command, so both interpreters resolve a published, hashed
wheel. Verified: pip on 3.11 selects 3.0.0 (cp311 wheel), pip on 3.13+
selects 3.1.0.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01REEc4WtvMHbGD23XK6xbLK
… extra The hash lock (fuzz/requirements-atheris.txt) selects atheris 3.0.0 for CPython <3.13 and 3.1.0 for >=3.13, but the pyproject [fuzz] extra only carried the <3.13 pin, so `pip install .[fuzz]` on CPython 3.13+ installed no atheris at all — the extra-install and lockfile-install paths diverged. Add the matching `atheris==3.1.0; python_version >= "3.13"` branch so both paths resolve the same dependency on every interpreter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01REEc4WtvMHbGD23XK6xbLK
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
📝 WalkthroughWalkthroughProvider HTTPS 통신에 DNS 주소 고정, 공용 주소 검증, TLS 호스트 보존, 리디렉션 차단을 추가했다. Atheris 의존성을 Python 버전별 릴리스와 SHA-256 해시로 잠그고, 관련 계약 테스트와 문서를 추가했다. ChangesProvider 전송 보안
Atheris 인터프리터별 잠금
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant ModelClient
participant _validated_public_addresses
participant _PinnedHTTPSConnection
participant Provider
ModelClient->>_validated_public_addresses: DNS 조회 및 공용 주소 검증
_validated_public_addresses-->>ModelClient: 검증된 IP 목록
ModelClient->>_PinnedHTTPSConnection: 고정 IP 연결과 원래 호스트명 전달
_PinnedHTTPSConnection->>Provider: TLS 요청 전송
Provider-->>ModelClient: 응답 반환
Possibly related issues
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
seonghobae
changed the title
|
@coderabbitai review |
|
|
@cwl-noema-review Please review exact head |
|
@opencode-agent @cwl-noema-review @coderabbitai review Please independently review exact current head |
|
@opencode-agent @cwl-noema-review Please independently review exact current head Repository Tests, Fuzz, Security, Security Scan, and SAST Semgrep all succeeded on this exact head, CodeRabbit status is successful, and all inline review threads are resolved. Verify the integrated DNS-answer pinning through the actual TLS socket, rejection of RFC 6598 and every other non-global address, proxy and redirect isolation, original-host authority/SNI/certificate verification, bounded retries and deterministic cleanup, side-effect-free package import, mutually exclusive Python-version Atheris markers and hash lock, no-egress install evidence, complete coverage/docstrings/package smoke evidence, and APA 7 doctoring. Submit APPROVE only if this exact head has no actionable blocker, while preserving the existing reviewer credential and authority boundaries. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/contextual-orchestrator'
pr='96'
sha='03124cf97b7bf02e30a48a13acfd78b6ef08d1ef'
echo '== exact revision =='
printf 'checked_out='
git rev-parse HEAD
git status --short
echo '== PR metadata and requested range =='
gh pr view "$pr" --repo "$repo" \
--json baseRefOid,headRefOid,mergeStateStatus,reviewDecision,isDraft \
--jq '{baseRefOid,headRefOid,mergeStateStatus,reviewDecision,isDraft}'
base="$(gh pr view "$pr" --repo "$repo" --json baseRefOid --jq .baseRefOid)"
git diff --name-status "$base...$sha"
echo '== source outlines =='
ast-grep outline contextual_orchestrator/provider_transport.py --items all
ast-grep outline contextual_orchestrator/orchestrator.py --items all
ast-grep outline contextual_orchestrator/__init__.py --items all
echo '== provider transport and ModelClient request path =='
cat -n contextual_orchestrator/provider_transport.py
rg -n -C 12 '\b(class ModelClient|_validate_provider|_open_provider|request_pinned|urlopen|ProxyHandler|build_opener|loopback|HTTPError)\b' \
contextual_orchestrator/orchestrator.py contextual_orchestrator/__init__.py
echo '== provider, HTTP-seam, and import-contract tests =='
fd -HI -t f -E .git | rg '(^|/)(test_.*(provider|security|import|package).*\.py|.*provider.*\.py)$'
rg -n -C 4 '\b(pinned|redirect|proxy|SNI|server_hostname|non_global|100\.64|loopback|userinfo|ModelClient|import)\b' \
tests contextual_orchestrator || true
echo '== Atheris metadata, universal lock, and lock tests =='
rg -n -C 5 '\batheris\b' pyproject.toml fuzz/requirements-atheris.in fuzz/requirements-atheris.txt
cat -n tests/test_fuzz_dependency_lock.py
echo '== CI workflow boundaries and publication-workflow scan =='
fd -HI -t f -E .git .github | sort
rg -n -i -C 3 '(requirements-atheris|requirements-property|require-hashes|pip install|uv pip|publish|release|twine)' \
.github fuzz pyproject.toml 2>/dev/null || true
echo '== changelog and doctoring =='
cat -n CHANGELOG.md
cat -n docs/doctoring/atheris-interpreter-lock.md
echo '== exact-head checks, reviews, and unresolved threads =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[] | [.name,.status,.conclusion,.details_url] | `@tsv`'
gh pr view "$pr" --repo "$repo" --json reviews \
--jq '.reviews[] | [.author.login,.state,.commit.oid] | `@tsv`'
gh api graphql -F owner='ContextualWisdomLab' -F name='contextual-orchestrator' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved
isOutdated
path
line
comments(first: 10) { nodes { author { login } body } }
}
}
}
}
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] |
select(.isResolved == false) |
{path,line,isOutdated,comments: [.comments.nodes[] | {author: .author.login,body}]}'
echo '== branch protection query =='
gh api "repos/$repo/branches/main/protection/required_status_checks" \
--jq '{strict,contexts,checks}' 2>&1 || trueLength of output: 240660 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/contextual-orchestrator'
pr='96'
base='6841b71935e0b7cb98fb52bcb4709cc5100c8d87'
sha='03124cf97b7bf02e30a48a13acfd78b6ef08d1ef'
echo '== complete HTTPS dispatch and validation =='
sed -n '330,430p' contextual_orchestrator/orchestrator.py
sed -n '567,621p' contextual_orchestrator/orchestrator.py
echo '== focused regression tests for HTTPS and loopback HTTP =='
sed -n '140,480p' tests/test_provider_address_pinning.py
sed -n '227,380p' tests/test_security_hardening.py
echo '== exact diff for transport, package-import contract, and workflow policy files =='
git diff --find-renames "$base...$sha" -- \
contextual_orchestrator/__init__.py \
contextual_orchestrator/orchestrator.py \
contextual_orchestrator/provider_transport.py \
tests/test_provider_address_pinning.py \
.github/workflows/tests.yml \
.github/workflows/fuzz.yml \
.github/workflows/security.yml
echo '== model-routing and credential authority changes in the exact PR range =='
git diff --name-only "$base...$sha" | rg -n '(credential|agent|model|router|routing|workflow|review|token|secret|\.github)' || true
git diff --find-renames "$base...$sha" -- \
contextual_orchestrator/credentials.py \
contextual_orchestrator/cost_router.py \
contextual_orchestrator/batch_routing.py \
.github || true
echo '== lock hashes compared with current PyPI artifacts =='
for version in 3.0.0 3.1.0; do
echo "-- atheris $version --"
published="$(mktemp)"
locked="$(mktemp)"
curl --fail --silent --show-error "https://pypi.org/pypi/atheris/$version/json" |
jq -r '.urls[].digests.sha256' | sort -u > "$published"
awk -v version="$version" '
$0 ~ "^atheris==" version " " { active=1; next }
active && /^atheris==/ { active=0 }
active && match($0, /sha256:[0-9a-f]{64}/) {
print substr($0, RSTART + 7, 64)
}
' fuzz/requirements-atheris.txt | sort -u > "$locked"
echo 'locked hashes missing from PyPI:'
comm -23 "$locked" "$published"
echo 'PyPI hashes omitted by lock:'
comm -13 "$locked" "$published"
rm -f "$published" "$locked"
done
echo '== exact-head coverage and installation evidence =='
for pair in \
'coverage-evidence:30988918876' \
'Python supply chain:30988920344' \
'Full unit and contract suite:30988920408' \
'Atheris coverage-guided:30988920371' \
'Hypothesis property tests:30988920371'; do
name="${pair%%:*}"
run_id="${pair##*:}"
echo "-- $name / run $run_id --"
gh run view "$run_id" --repo "$repo" --log 2>&1 | rg -n -i -C 2 -- \
'(100%|branch|statement|docstring|interrogate|requirements-atheris|requirements-property|atheris==|require-hashes|pip install|no-deps -e|pytest)' \
|| true
done
echo '== final non-success checks and PR state =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[] |
select(.status != "completed" or (.conclusion != "success" and .conclusion != "neutral" and .conclusion != "skipped")) |
[.name,.status,.conclusion,.details_url] | `@tsv`'
gh pr view "$pr" --repo "$repo" \
--json headRefOid,mergeStateStatus,reviewDecision,statusCheckRollup \
--jq '{headRefOid,mergeStateStatus,reviewDecision,statusCheckRollup: [.statusCheckRollup[] | {name,status,conclusion}]}'Length of output: 120531 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/contextual-orchestrator'
pr='96'
sha='03124cf97b7bf02e30a48a13acfd78b6ef08d1ef'
echo '== scoped Atheris hash verification =='
for version in 3.0.0 3.1.0; do
echo "-- atheris $version --"
published="$(mktemp)"
locked="$(mktemp)"
curl --fail --silent --show-error "https://pypi.org/pypi/atheris/$version/json" |
jq -r '.urls[].digests.sha256' | sort -u > "$published"
sed -n "/^atheris==${version}[[:space:]]/,/^ # via/p" fuzz/requirements-atheris.txt |
rg -o 'sha256:[0-9a-f]{64}' |
cut -d: -f2 |
sort -u > "$locked"
echo 'locked hashes missing from PyPI:'
comm -23 "$locked" "$published"
echo 'PyPI hashes omitted by lock:'
comm -13 "$locked" "$published"
rm -f "$published" "$locked"
done
echo '== current exact-head checks and PR state =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[] |
select(.status != "completed" or (.conclusion != "success" and .conclusion != "neutral" and .conclusion != "skipped")) |
[.name,.status,.conclusion,.details_url] | `@tsv`'
gh pr view "$pr" --repo "$repo" \
--json headRefOid,mergeStateStatus,reviewDecision,statusCheckRollup \
--jq '{headRefOid,mergeStateStatus,reviewDecision,statusCheckRollup: [.statusCheckRollup[] | select(.name == "strix") | {name,status,conclusion}]}'Length of output: 2067
I found no actionable code defect. Verified items:
I cannot submit formal approval yet. The You are interacting with an AI system. |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head03124cf97b7bf02e30a48a13acfd78b6ef08d1ef. -
Head SHA:
03124cf97b7bf02e30a48a13acfd78b6ef08d1ef -
Workflow run: 30993469598
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (8 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (8 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head03124cf97b7bf02e30a48a13acfd78b6ef08d1ef. -
Head SHA:
03124cf97b7bf02e30a48a13acfd78b6ef08d1ef -
Workflow run: 30993469598
-
Workflow attempt: 2
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (8 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (8 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
|
@opencode-agent @cwl-noema-review Re-run exact-head coverage and review for |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head03124cf97b7bf02e30a48a13acfd78b6ef08d1ef. -
Head SHA:
03124cf97b7bf02e30a48a13acfd78b6ef08d1ef -
Workflow run: 30993469598
-
Workflow attempt: 3
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (8 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (8 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
|
@opencode-agent @cwl-noema-review @coderabbitai review Please independently review exact current head Run fresh trusted statement/branch/docstring/package evidence using the repaired branch-referenced central workflow at |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/contextual-orchestrator'
pr='96'
base='6841b71935e0b7cb98fb52bcb4709cc5100c8d87'
sha='8b479f5667e92b39a6c611cb58cfa6f39a9cfa0f'
echo '== Exact revision and pull request state =='
printf 'checked_out='; git rev-parse HEAD
git status --short
gh pr view "$pr" --repo "$repo" \
--json baseRefOid,headRefOid,mergeStateStatus,reviewDecision,isDraft,statusCheckRollup \
--jq '{baseRefOid,headRefOid,mergeStateStatus,reviewDecision,isDraft,statusCheckRollup: [.statusCheckRollup[] | {name,status,conclusion,detailsUrl}]}'
echo '== Exact requested range =='
git diff --name-status "$base...$sha"
git diff --stat "$base...$sha"
git log --format='%H %s' "$base..$sha"
echo '== Source maps =='
ast-grep outline contextual_orchestrator/provider_transport.py --items all
ast-grep outline contextual_orchestrator/orchestrator.py --items all
ast-grep outline contextual_orchestrator/__init__.py --items all
echo '== Provider transport =='
cat -n contextual_orchestrator/provider_transport.py
echo '== ModelClient validation and dispatch =='
rg -n -C 12 '\b(class ModelClient|_validate_provider|_open_provider|request_pinned|urlopen|HTTPConnection|HTTPSConnection|ProxyHandler|build_opener|loopback|userinfo|HTTPError)\b' \
contextual_orchestrator/orchestrator.py contextual_orchestrator/__init__.py
echo '== Relevant regression tests =='
fd -HI -t f -E .git | rg '(^|/)(test_.*(provider|security|import|package|fuzz).*\.py|.*provider.*\.py)$' | sort
rg -n -C 4 '\b(pinned|redirect|proxy|SNI|server_hostname|non_global|100\.64|loopback|userinfo|ModelClient|import|atheris)\b' \
tests contextual_orchestrator || true
echo '== Dependency metadata, lock, and lock tests =='
rg -n -C 5 '\batheris\b' pyproject.toml fuzz/requirements-atheris.in fuzz/requirements-atheris.txt
cat -n tests/test_fuzz_dependency_lock.py
echo '== Workflow definitions and trust boundary =='
fd -HI -t f -E .git .github | sort
rg -n -i -C 4 '(uses:|\.github@|ref:|coverage|interrogate|docstring|requirements-atheris|requirements-property|require-hashes|pip install|uv pip|publish|release|twine)' \
.github fuzz pyproject.toml 2>/dev/null || true
echo '== Documentation =='
cat -n CHANGELOG.md
cat -n docs/doctoring/atheris-interpreter-lock.md
rg -n -i -C 3 '(workflow|retry|trust|coverage|branch|statement|docstring|package)' \
docs CHANGELOG.md .github 2>/dev/null || true
echo '== Exact-head checks =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[] | [.name,.id,.status,.conclusion,.details_url] | `@tsv`'
gh api "repos/$repo/commits/$sha/status" \
--jq '.statuses[]? | [.context,.state,.target_url] | `@tsv`'
echo '== Requested run metadata =='
for run in 31012521588 31012520838 31012520512 31012520701 31012521103; do
gh run view "$run" --repo "$repo" \
--json databaseId,headSha,status,conclusion,workflowName,event,headBranch,url \
--jq '{databaseId,headSha,status,conclusion,workflowName,event,headBranch,url}'
done
echo '== Fresh exact-head coverage/package workflow evidence, excluding failed workflow =='
gh run list --repo "$repo" --commit "$sha" --limit 100 \
--json databaseId,workflowName,status,conclusion,createdAt,updatedAt,url \
--jq '.[] | select(.databaseId != 30993469598) | {databaseId,workflowName,status,conclusion,createdAt,updatedAt,url}'
for run in $(gh run list --repo "$repo" --commit "$sha" --limit 100 --json databaseId --jq '.[].databaseId'); do
if [ "$run" = '30993469598' ]; then continue; fi
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log 2>&1 | rg -n -i -C 2 -- \
'(100%|branch|statement|docstring|interrogate|package import|no-deps -e|requirements-atheris|requirements-property|require-hashes|atheris==|pip install|uv\.lock|reusable workflow|\.github@)' \
|| true
done
echo '== Unresolved review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='contextual-orchestrator' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved
isOutdated
path
line
comments(first: 10) { nodes { author { login } body } }
}
}
}
}
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] |
select(.isResolved == false) |
{path,line,isOutdated,comments: [.comments.nodes[] | {author: .author.login,body}]}'
echo '== Existing exact-head reviews and branch-protection visibility =='
gh pr view "$pr" --repo "$repo" --json reviews \
--jq '.reviews[] | [.author.login,.state,.commit.oid,.submittedAt] | `@tsv`'
gh api "repos/$repo/branches/main/protection/required_status_checks" \
--jq '{strict,contexts,checks}' 2>&1 || trueLength of output: 205520 🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/contextual-orchestrator'
pr='96'
base='6841b71935e0b7cb98fb52bcb4709cc5100c8d87'
sha='8b479f5667e92b39a6c611cb58cfa6f39a9cfa0f'
echo '== Revision and PR state =='
printf 'checked_out='; git rev-parse HEAD
gh pr view "$pr" --repo "$repo" \
--json headRefOid,mergeStateStatus,reviewDecision,isDraft \
--jq '{headRefOid,mergeStateStatus,reviewDecision,isDraft}'
echo '== Changed files and sensitive scope scan =='
git diff --name-status "$base...$sha"
git diff --name-only "$base...$sha" |
rg -n '(credential|secret|token|agent|model|router|routing|workflow|review)' || true
echo '== Provider transport implementation =='
cat -n contextual_orchestrator/provider_transport.py
echo '== ModelClient provider methods =='
rg -n -C 30 'def (_validate_provider|_open_provider)\b' contextual_orchestrator/orchestrator.py
echo '== Provider dispatch and loopback tests =='
rg -n '^\s*(def|class) ' tests/test_provider_address_pinning.py
sed -n '1,520p' tests/test_provider_address_pinning.py
sed -n '220,390p' tests/test_security_hardening.py
echo '== Side-effect-free package import tests =='
rg -n -C 10 '\b(import|__init__|side.effect|ModelClient)\b' \
tests/test_provider_address_pinning.py tests/test_security_hardening.py \
tests/test_package_import.py 2>/dev/null || true
cat -n contextual_orchestrator/__init__.py
echo '== Atheris partition and lock tests =='
rg -n -C 5 '\batheris\b' pyproject.toml fuzz/requirements-atheris.in fuzz/requirements-atheris.txt
cat -n tests/test_fuzz_dependency_lock.py
echo '== Workflow call references and fuzz-install separation =='
rg -n -C 5 '(uses:\s*ContextualWisdomLab/\.github/|`@main`|requirements-atheris|requirements-property|require-hashes|coverage-evidence|coverage-source-tree)' \
.github/workflows fuzz pyproject.toml 2>/dev/null || true
echo '== Fresh central coverage run metadata and selected log evidence =='
gh api "repos/$repo/actions/runs/31012516437" \
--jq '{id,head_sha,event,status,conclusion,workflow_id,path,created_at,updated_at,html_url}'
gh run view 31012516437 --repo "$repo" --log 2>&1 |
rg -n -i -C 3 -- \
'(100%|branch|statement|docstring|interrogate|package import|no-deps -e|uv\.lock|materiali[sz]|reusable workflow|\.github@main|coverage-evidence|coverage-source-tree)' \
|| true
echo '== Exact-head workflow run records, including Security Scan =='
for run in 31012520701 31012521103; do
gh api "repos/$repo/actions/runs/$run" \
--jq '{id,name,path,head_sha,event,status,conclusion,workflow_id,created_at,updated_at,html_url}'
done
echo '== Atheris and supply-chain install evidence =='
for run in 31012520838 31012520512; do
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log 2>&1 |
rg -n -i -C 3 -- \
'(requirements-atheris|requirements-property|require-hashes|atheris==|pip install|uv pip)' \
|| true
done
echo '== Current exact-head non-success checks =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[] |
select(.status != "completed" or (.conclusion != "success" and .conclusion != "neutral" and .conclusion != "skipped")) |
[.name,.status,.conclusion,.details_url] | `@tsv`'
echo '== Unresolved review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='contextual-orchestrator' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved
isOutdated
path
line
comments(first: 10) { nodes { author { login } body } }
}
}
}
}
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] |
select(.isResolved == false) |
{path,line,isOutdated,comments: [.comments.nodes[] | {author: .author.login,body}]}'
echo '== Branch-protection visibility =='
gh api "repos/$repo/branches/main/protection/required_status_checks" \
--jq '{strict,contexts,checks}' 2>&1 || trueLength of output: 4132
Repository setup failed before the focused evidence collection. The failure prevents verification of the source, tests, workflow trust boundary, fresh coverage evidence, unresolved threads, and current merge gates. The earlier partial output is not sufficient for approval. Please retry the review after repository access is available. You are interacting with an AI system. |
|
@opencode-agent @cwl-noema-review Please independently review exact current head |
|
@coderabbitai review Retry the exact-head review after the prior transient rate-limit response. Review only head |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
repo='ContextualWisdomLab/contextual-orchestrator'
pr='96'
base='6841b71935e0b7cb98fb52bcb4709cc5100c8d87'
sha='8b479f5667e92b39a6c611cb58cfa6f39a9cfa0f'
echo '== revision and PR state =='
printf 'checked_out='; git rev-parse HEAD
git status --short
gh pr view "$pr" --repo "$repo" \
--json baseRefOid,headRefOid,mergeStateStatus,reviewDecision,isDraft,statusCheckRollup \
--jq '{baseRefOid,headRefOid,mergeStateStatus,reviewDecision,isDraft,statusCheckRollup:[.statusCheckRollup[]|{name,status,conclusion}]}'
echo '== requested diff =='
git diff --name-status "$base...$sha"
git diff --stat "$base...$sha"
echo '== source outlines =='
ast-grep outline contextual_orchestrator/provider_transport.py --items all
ast-grep outline contextual_orchestrator/orchestrator.py --items all
ast-grep outline contextual_orchestrator/__init__.py --items all
echo '== provider transport and ModelClient provider methods =='
cat -n contextual_orchestrator/provider_transport.py
rg -n -C 24 'def (_validate_provider|_open_provider)\b' \
contextual_orchestrator/orchestrator.py
cat -n contextual_orchestrator/__init__.py
echo '== focused tests =='
fd -HI -t f -E .git | rg '(^|/)(test_.*(provider|security|package|fuzz).*\.py)$' | sort
sed -n '1,540p' tests/test_provider_address_pinning.py
sed -n '220,410p' tests/test_security_hardening.py
cat -n tests/test_fuzz_dependency_lock.py
echo '== Atheris metadata and lock =='
rg -n -C 6 '\batheris\b' \
pyproject.toml fuzz/requirements-atheris.in fuzz/requirements-atheris.txt
echo '== workflow and policy boundary =='
fd -HI -t f -E .git .github | sort
rg -n -i -C 4 \
'(ContextualWisdomLab/\.github|`@main`|requirements-atheris|requirements-property|require-hashes|coverage|interrogate|docstring|publish|release|twine)' \
.github fuzz pyproject.toml docs CHANGELOG.md 2>/dev/null || true
echo '== exact-head checks and specified runs =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[] | [.name,.status,.conclusion,.details_url] | `@tsv`'
for run in 31012521588 31012520838 31012520512 31012520701 31012521103; do
gh run view "$run" --repo "$repo" \
--json databaseId,headSha,status,conclusion,workflowName,event,url \
--jq '{databaseId,headSha,status,conclusion,workflowName,event,url}'
done
echo '== fresh coverage/package evidence, excluding prior failed workflow =='
gh run list --repo "$repo" --commit "$sha" --limit 100 \
--json databaseId,workflowName,status,conclusion,url \
--jq '.[] | select(.databaseId != 30993469598) | {databaseId,workflowName,status,conclusion,url}'
for run in $(gh run list --repo "$repo" --commit "$sha" --limit 100 --json databaseId --jq '.[].databaseId'); do
[ "$run" = '30993469598' ] && continue
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log 2>&1 |
rg -n -i -C 2 -- \
'(100%|branch|statement|docstring|interrogate|package import|no-deps -e|uv\.lock|materiali[sz]|requirements-atheris|requirements-property|require-hashes|atheris==)' \
|| true
done
echo '== unresolved threads and branch-protection visibility =='
gh api graphql -F owner='ContextualWisdomLab' -F name='contextual-orchestrator' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved isOutdated path line
comments(first: 10) { nodes { author { login } body } }
}
}
}
}
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false) | {path,line,isOutdated,comments:[.comments.nodes[]|{author:.author.login,body}]}'
gh api "repos/$repo/branches/main/protection/required_status_checks" \
--jq '{strict,contexts,checks}' 2>&1 || trueLength of output: 183399 🏁 Script executed: #!/bin/bash
set -u -o pipefail
repo='ContextualWisdomLab/contextual-orchestrator'
pr='96'
base='6841b71935e0b7cb98fb52bcb4709cc5100c8d87'
sha='8b479f5667e92b39a6c611cb58cfa6f39a9cfa0f'
echo '== complete ModelClient transport methods =='
sed -n '190,220p' contextual_orchestrator/orchestrator.py
sed -n '330,435p' contextual_orchestrator/orchestrator.py
sed -n '567,630p' contextual_orchestrator/orchestrator.py
echo '== exact changed transport and test diff =='
git diff --find-renames "$base...$sha" -- \
contextual_orchestrator/__init__.py \
contextual_orchestrator/orchestrator.py \
contextual_orchestrator/provider_transport.py \
tests/test_provider_address_pinning.py \
tests/test_security_hardening.py
echo '== changed workflow files and credential/routing scope =='
git diff --name-only "$base...$sha" | rg -n \
'(^\.github/|credential|secret|token|agent|model|router|routing|workflow|review)' || true
echo '== exact current review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='contextual-orchestrator' -F number="$pr" -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved isOutdated path line
comments(first: 10) { nodes { author { login } body } }
}
}
}
}
}' --jq '.data.repository.pullRequest.reviewThreads.nodes[] | select(.isResolved == false) | {path,line,isOutdated,comments:[.comments.nodes[]|{author:.author.login,body}]}' \
|| echo 'review-thread query failed'
echo '== exact current non-success checks =='
gh api "repos/$repo/commits/$sha/check-runs?per_page=100" \
--jq '.check_runs[] | select(.status != "completed" or (.conclusion != "success" and .conclusion != "neutral" and .conclusion != "skipped")) | [.name,.status,.conclusion,.details_url] | `@tsv`' \
|| echo 'check-run query failed'
echo '== fresh run evidence, excluding 30993469598 =='
gh run list --repo "$repo" --commit "$sha" --limit 100 \
--json databaseId,workflowName,status,conclusion,url \
--jq '.[] | select(.databaseId != 30993469598) | {databaseId,workflowName,status,conclusion,url}' \
|| echo 'run-list query failed'
for run in 31012516437 31012521588 31012520838 31012520512 31012521103; do
echo "-- run $run --"
gh run view "$run" --repo "$repo" --log 2>&1 | rg -n -i -C 2 -- \
'(100%|branch|statement|docstring|interrogate|package import|no-deps -e|uv\.lock|materiali[sz]|requirements-atheris|requirements-property|require-hashes|atheris==)' \
|| true
done
echo '== Atheris PyPI hash comparison =='
for version in 3.0.0 3.1.0; do
echo "-- atheris $version --"
published="$(mktemp)"
locked="$(mktemp)"
curl --fail --silent --show-error "https://pypi.org/pypi/atheris/$version/json" |
jq -r '.urls[].digests.sha256' | sort -u > "$published" || true
sed -n "/^atheris==${version}[[:space:]]/,/^ # via/p" fuzz/requirements-atheris.txt |
rg -o 'sha256:[0-9a-f]{64}' | cut -d: -f2 | sort -u > "$locked"
echo 'locked hashes absent from PyPI:'
comm -23 "$locked" "$published" || true
echo 'PyPI hashes omitted from lock:'
comm -13 "$locked" "$published" || true
rm -f "$published" "$locked"
done
echo '== branch-protection visibility and final PR state =='
gh api "repos/$repo/branches/main/protection/required_status_checks" \
--jq '{strict,contexts,checks}' 2>&1 || true
gh pr view "$pr" --repo "$repo" \
--json headRefOid,mergeStateStatus,reviewDecision,isDraft \
--jq '{headRefOid,mergeStateStatus,reviewDecision,isDraft}' || trueLength of output: 83811
I found no actionable code defect. Verified items:
I cannot verify branch-protection requirements. GitHub returned HTTP 403 for that query. GitHub currently reports To submit a formal approval, use the explicit top-level command You are interacting with an AI system. |
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head8b479f5667e92b39a6c611cb58cfa6f39a9cfa0f. -
Head SHA:
8b479f5667e92b39a6c611cb58cfa6f39a9cfa0f -
Workflow run: 31022005762
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (8 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (8 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs (3 files)"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs (3 files)"]
R2 --> V2["docs review"]
Evidence --> S3["Test (3 files)"]
S3 --> I3["regression suite"]
I3 --> R3["Review risk: Test (3 files)"]
R3 --> V3["targeted test run"]
3 participants
Summary
Combines the validated provider-egress hardening from #76 with the interpreter-portable Atheris prerequisite needed by central same-head coverage evidence.
Provider egress
localhostor literal loopback IP addresses;ModelClient, with no import-time optional-adapter mutation;contextual_orchestrator.__init__;Portable fuzz lock
atheris==3.0.0below Python 3.13;atheris==3.1.0on Python 3.13 and later;--require-hashescompatibility;Evidence and doctoring
CHANGELOG.md.Exact integration identity
6841b71935e0b7cb98fb52bcb4709cc5100c8d878b479f5667e92b39a6c611cb58cfa6f39a9cfa0f241e9b24d1fd1bf2542371e0c3d770ac558c4f1231012521588; Fuzz31012520838; Security31012520512; Security Scan31012520701; SAST Semgrep31012521103.Every earlier-head check, review, approval, central coverage attempt, and merge-test result is stale. Queued, pending, or in-progress work is not success.
Current central prerequisite
Trusted same-head coverage is still blocked. The current OpenCode review on exact head
8b479f5667e92b39a6c611cb58cfa6f39a9cfa0frequested changes because coverage evidence run31022005762failed to prove the required test/docstring/package evidence.The central repair is ContextualWisdomLab/.github#759 at exact head
e151a1044e9a88b708c5628190da598a4203cfd6and basef070c504c1cb06891b800d7ab0cf6ac7d3cf8eae. Its direct exact-head diagnostics, trusted materializer, Python Security, Security Scan, CodeQL, Semgrep, Secret Scan, OSV, Scorecard, and SBOM workflows all succeeded; CodeRabbit found no new actionable source finding on that head; and every inline thread is resolved. It still requires a qualifying independent non-author approval and branch-policy acceptance before merge. Only after that protected-main merge may this PR regenerate authoritative current-head coverage and review evidence.Do not treat the already merged
.github#763, a predecessor central head, a queued or infrastructure-only result, or a prior OpenCode verdict as satisfying that prerequisite.Boundary
No model-selection policy, database object, persistent scheduler, reviewer identity, or review-agent credential scheme changes. Native Atheris execution remains in the dedicated Fuzz workflow. Generic coverage must materialize the exact current lock identity or fail closed; it must not accept stale cache evidence or make the platform-specific fuzz engine a prerequisite for ordinary coverage and package evidence.
Merge acceptance
Do not merge until current head
8b479f5667e92b39a6c611cb58cfa6f39a9cfa0fhas:No older approval or check result may be reused.
Closes #95.
Supersedes #76 after merge.
Depends on ContextualWisdomLab/.github#759.
Refs ContextualWisdomLab/.github#743 and #763.