Skip to content

🎨 Palette: Contextual aria-labels for table action items - #275

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette/ux-table-action-aria-labels-2395824393252047654
Closed

🎨 Palette: Contextual aria-labels for table action items#275
seonghobae wants to merge 1 commit into
mainfrom
palette/ux-table-action-aria-labels-2395824393252047654

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

🎨 Palette: [UX improvement]

πŸ’‘ What: Added contextual aria-label support to the generic table action elements (Details, Status JSON, Open viewer) in demo.js.
🎯 Why: Generic action buttons inside a data table lack context for screen reader users when navigating by interactive elements. Adding the relevant entity's name (the filename) to the aria-label resolves this.
β™Ώ Accessibility: Improves screen reader navigation and context for the session history data table.

  • Passed full mvn test suite.
  • Passed manual UI testing/Playwright frontend verification.

PR created automatically by Jules for task 2395824393252047654 started by @seonghobae

Added `aria-label` attribute support to the generic `createLink` and `createActionButton` functions in the viewer UI. Updated the `renderHistory` usage to append the document filename (e.g., "View details for document.pdf") to these action buttons. This provides crucial context for screen reader users when navigating tables with repetitive generic actions.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 30 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 5a397388-4f46-4eda-99af-72e18c6ab2f4

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between f3cc09a and 2969b1b.

πŸ“’ Files selected for processing (2)
  • .jules/palette.md
  • src/main/resources/static/assets/viewer/demo.js

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #264 exact head 718107a7a6eaca15a1f3e33ea7ceebefaf23d85a. #264 already provides document-specific accessible names for Details, Status JSON, and Open viewer, while also preserving inert filename rendering, exact DOM/ARIA state, nested asynchronous operations, duplicate-activation prevention, and executable integration plus 100% helper coverage. This branch contains only the narrower label change without those stronger tests and state guarantees, so no unique code remains to integrate.

@seonghobae seonghobae closed this Aug 5, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #264 exact head 718107a7a6eaca15a1f3e33ea7ceebefaf23d85a. #264 already provides document-specific accessible names for Details, Status JSON, and Open viewer, while also preserving inert filename rendering, exact DOM/ARIA state, nested asynchronous operations, duplicate-activation prevention, and executable integration plus 100% helper coverage. This branch contains only the narrower label change without those stronger tests and state guarantees, so no unique code remains to integrate.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant