Skip to content

🎨 Palette: 비동기 μ•‘μ…˜ λ²„νŠΌ λ‘œλ”© μ ‘κ·Όμ„± κ°œμ„  (aria-busy) - #272

Closed
seonghobae wants to merge 1 commit into
mainfrom
feat/palette-aria-busy-async-16348557646971806001
Closed

🎨 Palette: 비동기 μ•‘μ…˜ λ²„νŠΌ λ‘œλ”© μ ‘κ·Όμ„± κ°œμ„  (aria-busy)#272
seonghobae wants to merge 1 commit into
mainfrom
feat/palette-aria-busy-async-16348557646971806001

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

πŸ’‘ What

demo.js에 μ‘΄μž¬ν•˜λŠ” λͺ¨λ“  비동기 μž‘μ—… λ²„νŠΌμ΄ λ‘œλ”© μƒνƒœμΌ λ•Œ aria-busy="true" 속성을 갖도둝 μˆ˜μ •ν–ˆμŠ΅λ‹ˆλ‹€.

🎯 Why

슀크린 리더와 같은 보쑰 κΈ°κΈ°λ₯Ό μ‚¬μš©ν•˜λŠ” μ‚¬μš©μžμ—κ²Œ ν˜„μž¬ λ°±κ·ΈλΌμš΄λ“œμ—μ„œ 비동기 μž‘μ—…μ΄ μ§„ν–‰ μ€‘μž„μ„ λͺ…ν™•νžˆ 인지할 수 μžˆλ„λ‘ ν”Όλ“œλ°±μ„ μ œκ³΅ν•˜μ—¬, ν˜Όλž€μ„ λ°©μ§€ν•˜κ³  μ „λ°˜μ μΈ μ ‘κ·Όμ„±(a11y)을 높이기 μœ„ν•¨μž…λ‹ˆλ‹€.

β™Ώ Accessibility

비동기 λ²„νŠΌ(Details, retryActiveJob, refreshKpiEvidence, loadDemoData, submitDocument)의 λ‘œλ”© μƒνƒœ 쀑 aria-busy 속성을 μ„€μ •ν•˜μ—¬ 화면이 보이지 μ•ŠλŠ” μ‚¬μš©μžμ—κ²Œλ„ μƒνƒœ λ³€ν™”λ₯Ό λͺ…ν™•ν•˜κ²Œ μ•Œλ¦΄ 수 μžˆλ„λ‘ κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ“Έ Before/After

μ‹œκ°μ μΈ λ³€ν™”λŠ” μ—†μœΌλ©°, DOM의 aria-busy μ†μ„±λ§Œμ΄ μΆ”κ°€/μ œκ±°λ©λ‹ˆλ‹€. ν”„λ‘ νŠΈμ—”λ“œ 검증 슀크립트λ₯Ό 톡해 μŠ€ν¬λ¦°μƒ·κ³Ό μƒνƒœ 둜그λ₯Ό λ‚¨κ²ΌμŠ΅λ‹ˆλ‹€.


PR created automatically by Jules for task 16348557646971806001 started by @seonghobae

비동기 μž‘μ—…μ„ μˆ˜ν–‰ν•˜λŠ” λ²„νŠΌ(Details, retryActiveJob, refreshKpiEvidence, loadDemoData, submitDocument)이 μž‘μ—… 쀑일 λ•Œ aria-busy="true" 속성을 μ„€μ •ν•˜κ³  μž‘μ—… μ™„λ£Œ ν›„ μ œκ±°ν•˜μ—¬ 슀크린 리더 λ“± 보쑰 κΈ°κΈ° μ‚¬μš©μžμ˜ 접근성을 κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
λ”λΆˆμ–΄ .jules/palette.md에 κ΄€λ ¨λœ μ ‘κ·Όμ„± κ°œμ„  κ²½ν—˜μ„ ν•œκ΅­μ–΄λ‘œ κΈ°λ‘ν–ˆμŠ΅λ‹ˆλ‹€.
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
βš™οΈ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 283471f9-2eae-47c6-8dcc-77979c060eae

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between f3cc09a and e40035a.

πŸ“’ Files selected for processing (2)
  • .jules/palette.md
  • src/main/resources/static/assets/viewer/demo.js

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #264 exact head 718107a7a6eaca15a1f3e33ea7ceebefaf23d85a. #264 already applies aria-busy through one nested-safe, idempotent helper across the asynchronous viewer workflow, preserves pre-existing disabled/ARIA state and original child-node identities, adds operation-specific pending accessible names, and carries executable integration plus 100% production-helper coverage evidence. This PR duplicates only part of that behavior and restores disabled=false/removes aria-busy unconditionally, so merging it would regress #264's stronger state-restoration contract. No code from this branch is required.

@seonghobae seonghobae closed this Aug 5, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #264 exact head 718107a7a6eaca15a1f3e33ea7ceebefaf23d85a. #264 already applies aria-busy through one nested-safe, idempotent helper across the asynchronous viewer workflow, preserves pre-existing disabled/ARIA state and original child-node identities, adds operation-specific pending accessible names, and carries executable integration plus 100% production-helper coverage evidence. This PR duplicates only part of that behavior and restores disabled=false/removes aria-busy unconditionally, so merging it would regress #264's stronger state-restoration contract. No code from this branch is required.

Understood. Acknowledging that this work is superseded and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant