🛡️ Sentinel: [HIGH] 관리자 엔드포인트 인증/인가 누락 취약점 수정 - #219
Conversation
`AdminController`의 `getAllJobs`, `deleteJob`, `retryDeadLettered` 엔드포인트에 인증/인가가 누락되어 비인가 접근 및 정보 노출 취약점이 존재했습니다. 이를 해결하기 위해 `TenantAccessService`를 주입하고, `TenantPermissions.ADMIN_READ` 및 `TenantPermissions.ADMIN_WRITE` 검증을 추가하여 보안을 강화했습니다.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 13 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR addresses a high-severity authorization gap by enforcing tenant-authenticated permission checks on admin conversion endpoints, aligning admin operations with the existing TenantAccessService-based security model used elsewhere in the viewer service.
Changes:
- Added
ADMIN_READ/ADMIN_WRITEpermission constants toTenantPermissions. - Updated
AdminControllerto require authenticated tenant claims + permissions for listing, deleting, and retrying conversion jobs. - Updated related test scaffolding and refreshed PR metadata/docs to reflect the admin-endpoint auth fix.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/clearfolio/viewer/controller/AdminController.java | Enforces admin read/write permissions via TenantAccessService.require(...) on admin endpoints. |
| src/main/java/com/clearfolio/viewer/auth/TenantPermissions.java | Adds new admin permission constants used by the controller guards. |
| src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java | Adjusts controller construction and request setup to accommodate the new auth guard. |
| .jules/sentinel.md | Records the security learning/prevention note for the admin auth issue. |
| description.txt | Updates the PR description text to match the admin auth vulnerability/fix. |
| commit_message.txt | Updates the commit message to reflect the admin auth/authorization change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| tenantAccessService.require(headers, TenantPermissions.ADMIN_WRITE); | ||
| RetryDeadLetterResult result = conversionService.retryDeadLettered(jobId, "admin"); |
| .uri("/api/v1/admin/convert/jobs") | ||
| .header("Authorization", "Bearer test") | ||
| .exchange() |
Superseded by #172, the canonical least-privilege admin authorization patch with successful exact-head CI and security validation.