๐จ Palette: ๋ฐ๋ณต์ ์ธ ํ ์ด๋ธ ์ก์ ๋ฒํผ์ ๋ํ ๋์ ARIA ๋ผ๋ฒจ ์ถ๊ฐ ๋ฐ ๋ก๋ฉ ์ํ ์ ๊ทผ์ฑ ๊ฐ์ - #213
Conversation
- ์ ๊ทผ์ฑ ํฅ์์ ์ํด ํ ์ด๋ธ์ ๋ฐ๋ณต์ ์ธ ์ก์ ๋ฒํผ์ ๊ณ ์ ํ ํ ์๋ณ์๋ฅผ ํฌํจํ `aria-label`์ ๋์ ์ผ๋ก ์์ฑํ์ฌ ์ถ๊ฐํจ. - "Details" ๋ฒํผ์ ๋น๋๊ธฐ ๋ก๋ฉ ์ํ ๋์ `aria-label`์ด "Loading..."์ผ๋ก ์์ ๋ณ๊ฒฝ๋ ํ, ์์ ์๋ฃ ์ ๊ธฐ์กด ์์ฑ๊ฐ์ผ๋ก ์ฌ๋ฐ๋ฅด๊ฒ ๋ณต์๋๋๋ก ์ฒ๋ฆฌํจ. - `.jules/palette.md` ํ์ผ์ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ปจํ ์คํธ ํฅ์๊ณผ ๊ด๋ จ๋ UX ํ์ต ๊ธฐ๋ก์ ์ถ๊ฐํจ. - ๊ด๋ จ ๋ด์ฉ์ CHANGELOG์ ๊ธฐ๋กํจ.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review detailsโ๏ธ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ๐ Files selected for processing (3)
โจ Finishing Touches๐งช Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
This PR improves screen reader accessibility on the Clearfolio viewer demo page by adding row-specific aria-label values to repetitive table action controls and by adjusting how ARIA metadata is handled during async loading transitions. It also documents the UX learnings and attempts to record the change in the changelog.
Changes:
- Updated
demo.jshelpers (createLink,createActionButton) to accept optionalaria-label, and injected row-specific labels for โDetailsโ, โStatus JSONโ, and โOpen viewerโ. - Preserved/restored
aria-labelaround the โDetailsโ button loading/disabled state transition. - Added related UX notes to
.jules/palette.mdand a changelog entry.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/resources/static/assets/viewer/demo.js | Adds optional ARIA-label support and supplies row-specific labels for repeated table actions, with loading-state label handling. |
| CHANGELOG.md | Adds an Unreleased changelog entry describing the accessibility improvements (but currently introduces a duplicate Unreleased section). |
| .jules/palette.md | Records the accessibility learning/action item for dynamic row-specific ARIA labels and loading-state ARIA restoration. |
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const originalAriaLabel = btn.getAttribute("aria-label"); | ||
| btn.disabled = true; | ||
| btn.setAttribute("aria-label", "Loading..."); | ||
| btn.textContent = "Loading..."; |
| ## [Unreleased] | ||
| ### Added | ||
| - [UX] ๋ฐ๋ณต์ ์ธ ํ ์ด๋ธ ์ก์ ๋ฒํผ("Details", "Status JSON", "Open viewer")์ ํ ํน์ `aria-label`์ ๋์ ์ผ๋ก ์ถ๊ฐํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์์ ์ ๊ทผ์ฑ์ ๊ฐ์ ํ์ต๋๋ค. | ||
| - [UX] ๋น๋๊ธฐ ์์ ์ค "Details" ๋ฒํผ์ด "Loading..." ์ํ๋ก ์ ํ๋ ๋ ๊ธฐ์กด `aria-label`์ด ์ฌ๋ฐ๋ฅด๊ฒ ๋ณด์กด ๋ฐ ๋ณต์๋๋๋ก ์์ ํ์ต๋๋ค. |
Superseded by #162.