Admin API 권한(Authorization) 검증 추가

[seonghobae]

Superseded by #172, which is the canonical and already validated implementation of admin read/write authorization across all admin endpoints.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[Copilot]

Pull request overview

Admin 전용 변환 작업 관리 엔드포인트가 무권한으로 호출 가능했던 보안 취약점을 해소하기 위해, TenantAccessService 기반의 권한(permissions) 검증을 AdminController에 추가한 PR입니다. Clearfolio Viewer의 테넌트/권한 헤더 기반 접근제어 모델을 Admin API에도 동일하게 적용합니다.

Changes:

• AdminController의 관리자 API 3개 엔드포인트에 ADMIN_READ/ADMIN_WRITE 권한 검증을 추가
• TenantPermissions에 관리자 권한 상수 2종(admin:read, admin:write) 추가
• 테스트(AdminControllerTest) 및 변경 로그(CHANGELOG.md) 업데이트

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
src/main/java/com/clearfolio/viewer/controller/AdminController.java	Admin API 요청 헤더를 받아 TenantAccessService.require(..., ADMIN_*)로 인가 검증 수행
src/main/java/com/clearfolio/viewer/auth/TenantPermissions.java	관리자 전용 권한 문자열 상수 ADMIN_READ/ADMIN_WRITE 추가
src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java	변경된 컨트롤러 생성자/인가 흐름에 맞춰 테스트 보정 (단, 컴파일/검증 이슈 코멘트 남김)
CHANGELOG.md	“관리자 API 권한 검증 추가” 항목을 Unreleased 섹션에 기록

Comments suppressed due to low confidence (5)

src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java:74

• This test should also verify that the authorization guard is invoked with ADMIN_READ, otherwise the new permission requirement isn’t actually validated by the test.

        webTestClient.get()
                .uri("/api/v1/admin/convert/jobs?deadLettered=true")
                .header("X-Dummy", "dummy")
                .exchange()
                .expectStatus().isOk()

src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java:92

• This test should verify that the authorization guard is invoked with ADMIN_READ, otherwise the permission check could be removed/changed without failing tests.

        webTestClient.get()
                .uri("/api/v1/admin/convert/jobs?deadLettered=false")
                .header("X-Dummy", "dummy")
                .exchange()
                .expectStatus().isOk()

src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java:118

• This test should assert that the new authorization guard is invoked with ADMIN_WRITE for the retry endpoint.

        webTestClient.post()
                .uri("/api/v1/admin/convert/jobs/" + jobId + "/retry")
                .header("X-Dummy", "dummy")
                .exchange()
                .expectStatus().isAccepted();

src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java:130

• This test should assert that the new authorization guard is invoked with ADMIN_WRITE for the retry endpoint.

        webTestClient.post()
                .uri("/api/v1/admin/convert/jobs/" + jobId + "/retry")
                .header("X-Dummy", "dummy")
                .exchange()
                .expectStatus().isNotFound();

src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java:143

• This test should assert that the new authorization guard is invoked with ADMIN_WRITE for the retry endpoint.

        webTestClient.post()
                .uri("/api/v1/admin/convert/jobs/" + jobId + "/retry")
                .header("X-Dummy", "dummy")
                .exchange()
                .expectStatus().isEqualTo(409); // isConflict() isn't always available depending on spring-test version, so using isEqualTo(409) is safer
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.