Skip to content

🎨 Palette: 동적 테이블의 반복 액션 버튼에 접근성을 위한 aria-label 추가 - #199

Closed
seonghobae wants to merge 1 commit into
mainfrom
palette/a11y-table-action-aria-labels-6654464048468196201
Closed

🎨 Palette: 동적 테이블의 반복 액션 버튼에 접근성을 위한 aria-label 추가#199
seonghobae wants to merge 1 commit into
mainfrom
palette/a11y-table-action-aria-labels-6654464048468196201

Conversation

@seonghobae

@seonghobae seonghobae commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Superseded by #162, which already contains this contextual table-action accessibility change.

데이터 테이블의 각 행에 있는 'Details', 'Status JSON', 'Open viewer' 버튼 및 링크들은 스크린 리더 사용자에게 컨텍스트 없는 동일한 텍스트로 읽히는 문제가 있었습니다.
이를 해결하기 위해 DOM 요소를 생성하는 헬퍼 함수(`createActionButton`, `createLink`)에 선택적 인수로 `ariaLabel`을 추가하고, 행 생성 시 파일명을 포함한 명시적인 `aria-label`을 부여하여 접근성을 개선했습니다.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copilot AI review requested due to automatic review settings July 24, 2026 20:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the accessibility of the static demo table UI in the viewer by providing context-aware accessible names for repeated action controls, so screen readers can distinguish identical “Details” / “Status JSON” actions per row.

Changes:

  • Extend createLink and createActionButton helpers in demo.js to accept an optional ariaLabel parameter and apply it as aria-label when provided.
  • Add dynamic, per-row aria-label values (e.g., “Details for …”, “Status JSON for …”, “Open viewer for …”) when rendering history table actions.
  • Record the accessibility learning/pattern in .jules/palette.md for future consistency.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/main/resources/static/assets/viewer/demo.js Adds optional aria-label support to link/button helpers and uses it to disambiguate repeated table actions for screen readers.
.jules/palette.md Documents the accessibility learning and recommended pattern for context-aware labeling in dynamic tables.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@seonghobae seonghobae closed this Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants