🎨 Palette: 반복되는 테이블 액션에 대한 컨텍스트 특정 aria-label 추가 - #194
Conversation
- 스크린 리더 사용자를 위해 반복되는 테이블 작업(예: '세부 정보', 'Status JSON', 'Open viewer')에 파일 이름이 포함된 `aria-label`을 동적으로 추가하여 명확한 컨텍스트 제공 - 세부 정보 로딩 중 `aria-label`을 "Loading..."으로 업데이트하고 완료 후 복원 - UX/a11y 관련 학습 내용을 `.jules/palette.md`에 기록 - 테스트: 100% 자바 코드 커버리지 확인 및 Playwright를 통한 프론트엔드 검증 완료
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves accessibility in the static demo viewer UI by adding context-specific aria-label attributes to repetitive table actions so screen reader users can distinguish per-row actions (e.g., “Details”, “Status JSON”, “Open viewer”) based on the associated filename.
Changes:
- Add optional
aria-labelsupport to link/button factories and provide filename-specific labels for table actions. - Temporarily update the “Details” button label (and its
aria-label) during async loading, then restore the original state. - Record the accessibility learning in
.jules/palette.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/main/resources/static/assets/viewer/demo.js |
Adds filename-specific aria-labels to repetitive action buttons/links in the history table and updates the label during loading. |
.jules/palette.md |
Documents the new accessibility learning for context-specific ARIA labeling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| **Learning:** Adding explicit loading and disabled states to table action buttons that invoke asynchronous processes helps prevent redundant API calls and visually assures the user that their request is being handled. | ||
| **Action:** Consistently apply `disabled` state and `Loading...` text changes to inline table action buttons linked to async workflows, and carefully preserve underlying DOM structures with `Array.from(btn.childNodes)` during the loading cycle to avoid rendering regressions. | ||
|
|
||
| ## 2024-07-22 - Context-Specific ARIA Labels for Repetitive Table Actions |
Superseded by #162, which already implements the same contextual labels and loading-state accessibility behavior.