๐จ Palette: ํ ์ด๋ธ ์ก์ ๋ฒํผ์ ์ปจํ ์คํธ ๊ธฐ๋ฐ ARIA ๋ ์ด๋ธ ์ถ๊ฐ - #189
๐จ Palette: ํ
์ด๋ธ ์ก์
๋ฒํผ์ ์ปจํ
์คํธ ๊ธฐ๋ฐ ARIA ๋ ์ด๋ธ ์ถ๊ฐ#189seonghobae wants to merge 1 commit into
Conversation
๋ฐ๋ณต๋๋ ํ
์ด๋ธ ์ก์
๋ฒํผ("Details", "Status JSON", "Open viewer")์ ํ(row) ์ปจํ
์คํธ(ํ์ผ๋ช
)๋ฅผ ํฌํจํ ๋์ ์ธ ARIA ๋ ์ด๋ธ์ ์ถ๊ฐํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์์ ์ ๊ทผ์ฑ์ ํฅ์์์ผฐ์ต๋๋ค.
๋ํ ๋ก๋ฉ ์ํ ์ ํ ์ ๊ธฐ์กด ARIA ๋ ์ด๋ธ์ ์์๋ก "Loading..."์ผ๋ก ๋ฎ์ด์ฐ๊ณ ๋ณต์ํ๋๋ก ๊ฐ์ ํ์์ต๋๋ค.
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
There was a problem hiding this comment.
Pull request overview
This PR improves the accessibility of the static viewer demoโs history table by ensuring repetitive per-row actions (โDetailsโ, โStatus JSONโ, โOpen viewerโ) expose row-specific context to assistive technologies.
Changes:
- Added optional
ariaLabelparameters tocreateActionButtonandcreateLinkindemo.js. - Generated context-specific
aria-labelvalues for history-table actions using the rowโs filename, and temporarily switched the โDetailsโ buttonโsaria-labelto"Loading..."during async loading. - Documented the new โcontext-specific ARIA labelsโ practice in
.jules/palette.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/resources/static/assets/viewer/demo.js | Adds optional ARIA label support and applies contextual aria-labels (plus loading-state label override) to repetitive table actions. |
| .jules/palette.md | Records the accessibility learning/action guidance for context-specific ARIA labels in repetitive table actions. |
๐ก Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| openJobDetail(job).finally(() => { | ||
| btn.replaceChildren(...initialChildren); | ||
| btn.disabled = false; | ||
| if (originalAriaLabel) btn.setAttribute("aria-label", originalAriaLabel); | ||
| }); |
Superseded by #162, which already contains the same table-action accessibility change.